-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indent/Unindent Selected Lines #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-ludwig
requested review from
austincondiff,
matthijseikelenboom,
FastestMolasses and
thecoolwinter
October 8, 2024 09:31
austincondiff
force-pushed
the
feat/220/indentl-lines
branch
from
October 8, 2024 12:43
07450fa
to
63e644a
Compare
thecoolwinter
requested changes
Oct 9, 2024
Sources/CodeEditSourceEditor/Controller/TextViewController+IndentLines.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+IndentLines.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+IndentLines.swift
Outdated
Show resolved
Hide resolved
Sources/CodeEditSourceEditor/Controller/TextViewController+IndentLines.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>
thecoolwinter
approved these changes
Oct 12, 2024
austincondiff
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Shortcuts:
The keyboard shortcuts also work with multiple cursors.
Blocker:
1. The functions aren't connected to the editor's settings, meaning the space count is hardcoded to 2 spaces for now.2. In the current implementation, the user cannot use the Tab key as expected.Related Issues
Checklist
Screenshots