Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Indent selected lines #220

Closed
MattKindzerske opened this issue Nov 15, 2023 · 7 comments · Fixed by #266
Closed

✨ Indent selected lines #220

MattKindzerske opened this issue Nov 15, 2023 · 7 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request

Comments

@MattKindzerske
Copy link

MattKindzerske commented Nov 15, 2023

Description

When multiple lines are selected, the tab key should increase the indent of each line, instead of replacing the selected text with a tab.

When text is selected...

  • tab should increase indention level
  • tab should decrease indentation level
  • ] should increase indention level
  • [ should decrease indentation level

Screenshots

image
Screen.Recording.2023-11-15.at.2.20.45.PM.mov
@MattKindzerske MattKindzerske added the enhancement New feature or request label Nov 15, 2023
@austincondiff austincondiff transferred this issue from CodeEditApp/CodeEdit Dec 9, 2023
@austincondiff
Copy link
Collaborator

austincondiff commented Dec 9, 2023

@thecoolwinter is this possible with the new text view?

Along with tab, ⌘] and ⌘[ should increase and decrease respectively as well.

Edit: modified issue description

@austincondiff austincondiff changed the title Multiline indent for TAB ✨ Multiline indent with tab key Dec 9, 2023
@thecoolwinter
Copy link
Collaborator

@thecoolwinter is this possible with the new text view?

Along with tab, ⌘] and ⌘[ should increase and decrease respectively as well.

Yes it is, we'll just need to add some functionality to our tab replacement code. I'll work on getting this implemented next.

@austincondiff austincondiff changed the title ✨ Multiline indent with tab key ✨ Indent selected lines May 14, 2024
@ladvoc
Copy link
Contributor

ladvoc commented Aug 21, 2024

If you haven’t had a chance to work on this yet, I’m happy to step in. Let me know if that works for you.

@austincondiff
Copy link
Collaborator

@ladvoc I don't think anyone has started on this, I'd say go for it! Would you like me to assign this to you?

@ladvoc
Copy link
Contributor

ladvoc commented Aug 23, 2024

@ladvoc I don't think anyone has started on this, I'd say go for it! Would you like me to assign this to you?

Yes, please do.

@austincondiff
Copy link
Collaborator

austincondiff commented Aug 24, 2024

@ladvoc assigned to you. It may or may not make sense to also knock out #259 in the same PR.

@tom-ludwig
Copy link
Member

Hey @ladvoc, thanks a lot for taking the time to look into this issue! It seems there hasn't been much progress on it, so I’ve started working on it myself and it's already halfway done. I'll go ahead and assign it to myself and remove you.

@tom-ludwig tom-ludwig assigned tom-ludwig and unassigned ladvoc Sep 27, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Oct 12, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

5 participants