-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement different triggers to reset orders #273
Implement different triggers to reset orders #273
Commits on Aug 15, 2018
-
Implement different triggers to reset orders
- Always reset orders whether it was a filled, expired or manually cancelled order detected - Reset on partial fill (with % threshold, optional) - Allow to define custom order expiration time - Reset orders on market trade (optional) - Reset orders on center price change threshold (optional) - Also disable log message about correct orders to remove log noise - Writing of a trade log entry is disabled because we cannot properly distinguish an expired order from a filled one Closes: Codaone#226, Codaone#270
Configuration menu - View commit details
-
Copy full SHA for c9f139e - Browse repository at this point
Copy the full SHA c9f139eView commit details
Commits on Aug 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fae970b - Browse repository at this point
Copy the full SHA fae970bView commit details
Commits on Aug 28, 2018
-
Merge remote-tracking branch 'upstream/master' into 226-relative-orde…
…rs-reset-options
Configuration menu - View commit details
-
Copy full SHA for 3641cce - Browse repository at this point
Copy the full SHA 3641cceView commit details -
More proper fix for spamming log with "Oreders correct ..."
As described by @mikakoi: The point of logging "Orders correct on market" is that it's used as a status for the worker in the GUI. In a case where the strategy is initialized but no action is required to be done after it, a status message "Initializing Relative Orders" will get stuck on the GUI and that will just confuse the user. Code part is from 347eedf Closes: Codaone#270
Configuration menu - View commit details
-
Copy full SHA for 2fe2588 - Browse repository at this point
Copy the full SHA 2fe2588View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba80c10 - Browse repository at this point
Copy the full SHA ba80c10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 275ce1b - Browse repository at this point
Copy the full SHA 275ce1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f1da45 - Browse repository at this point
Copy the full SHA 9f1da45View commit details -
Call check_orders() on initialization instead of update_orders()
There are maybe old orders from previous run, so give a chance to them.
Configuration menu - View commit details
-
Copy full SHA for d1abe0d - Browse repository at this point
Copy the full SHA d1abe0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c43c0c2 - Browse repository at this point
Copy the full SHA c43c0c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7caf08b - Browse repository at this point
Copy the full SHA 7caf08bView commit details -
Reset orders on startup if is_reset_on_price_change active
We still need to cancel old orders on startup when "Reset orders on center price change" is active. We don't know what the center price was before.
Configuration menu - View commit details
-
Copy full SHA for 28e8dc8 - Browse repository at this point
Copy the full SHA 28e8dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 767dd9d - Browse repository at this point
Copy the full SHA 767dd9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b447161 - Browse repository at this point
Copy the full SHA b447161View commit details -
Remove reset_on_market_trade option
This is option is actually not needed because it's duplicating behavior of "Reset on center price change" with "threshold = 0"
Configuration menu - View commit details
-
Copy full SHA for db74ed7 - Browse repository at this point
Copy the full SHA db74ed7View commit details -
Do not ignore market update events while initializing
check_orders() are called from __init__(), so it will not work because initial "self.last_check = now"
Configuration menu - View commit details
-
Copy full SHA for 901e880 - Browse repository at this point
Copy the full SHA 901e880View commit details