Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative orders flooding log #270

Closed
juhanihaapala opened this issue Aug 10, 2018 · 1 comment
Closed

Relative orders flooding log #270

juhanihaapala opened this issue Aug 10, 2018 · 1 comment
Labels
[3] Type: Enhancement [4] Priority: Low

Comments

@juhanihaapala
Copy link
Member

Expected Behavior

Only log things that are meaningful

Actual Behavior

Relative orders is logging much "INFO - Orders correct on market"

Steps to Reproduce the Problem

  1. Start relative orders on any market
  2. Wait for couple minutes
  3. There comes "INFO - Orders correct on market" to log
@bitphage
Copy link
Collaborator

Agree, I personally turned this into debug for myself.

bitphage added a commit to bitphage/DEXBot that referenced this issue Aug 15, 2018
@bitphage
Implement different triggers to reset orders
c9f139e 
- Always reset orders whether it was a filled, expired or manually
cancelled order detected
- Reset on partial fill (with % threshold, optional)
- Allow to define custom order expiration time
- Reset orders on market trade (optional)
- Reset orders on center price change threshold (optional)

- Also disable log message about correct orders to remove log noise
- Writing of a trade log entry is disabled because we cannot properly
distinguish an expired order from a filled one

Closes: Codaone#226, Codaone#270
@bitphage bitphage mentioned this issue Aug 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[3] Type: Enhancement [4] Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bitphage @juhanihaapala @MarkoPaasila