Skip to content

Commit

Permalink
Build all cpp binaries of test_wheels ci job in the wheel-test-min
Browse files Browse the repository at this point in the history
…environment

Similar to rerun-io#6911
May fix Windows issues or at least make it easier to diagnose
  • Loading branch information
Wumpf committed Jul 29, 2024
1 parent e6e8c9a commit 6329bd9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/reusable_test_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,12 @@ jobs:
- name: Run e2e test
run: pixi run -e wheel-test-min RUST_LOG=debug python scripts/run_python_e2e_test.py --no-build # rerun-sdk is already built and installed

- name: Build all C++
if: ${{ !inputs.FAST }}
# Separated out of compare_snippet_output.py & roundtrips.py run so we control the pixi environment.
# This used to cause issues on Windows during the setup of the pixi environment when running from inside these scripts.
run: pixi run -e wheel-test-min cpp-build-all

- name: Check for archetype roundtrip tests
if: ${{ inputs.FAST }}
# Only check that we have the archetype roundtrip tests, but don't spend time actually running them
Expand All @@ -188,13 +194,7 @@ jobs:
# --release so we can inherit from some of the artifacts that maturin has just built before
# explicit target because otherwise cargo loses the target cache… even though this is the target anyhow…
# --no-py-build because rerun-sdk is already built and installed
run: pixi run -e wheel-test-min RUST_LOG=debug python tests/roundtrips.py --release --target ${{ needs.set-config.outputs.TARGET }} --no-py-build

- name: Build C++ examples
if: ${{ !inputs.FAST }}
# Separated out of compare_snippet_output.py run so we control the pixi environment.
# This used to cause issues on Windows during the setup of the pixi environment when running from inside `compare_snippet_output.py`.
run: pixi run -e wheel-test-min cpp-build-snippets
run: pixi run -e wheel-test-min RUST_LOG=debug python tests/roundtrips.py --release --target ${{ needs.set-config.outputs.TARGET }} --no-py-build --no-cpp-build

- name: Run docs/snippets/compare_snippet_output.py
if: ${{ !inputs.FAST }}
Expand Down
2 changes: 1 addition & 1 deletion tests/roundtrips.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def main() -> None:
print(f"Python and Rust examples ran in {elapsed:.1f} seconds")

print("----------------------------------------------------------")
print(f"Comparing recordings for{len(archetypes)} archetypes…")
print(f"Comparing recordings for {len(archetypes)} archetypes…")
start_time = time.time()

for arch in archetypes:
Expand Down

0 comments on commit 6329bd9

Please sign in to comment.