Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate C++ example build from snippet compare in order to set pixi environment consistently #6911

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 16, 2024

What

Shot in the dark to fix https://github.com/rerun-io/rerun/actions/runs/9951873366/job/27493385364
Rationale: Observed that the error happens during pixi setup script while being in the cpp environment nested in the wheel-test environment.

Testing: Works on my machine!

Checklist

  • checked

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jul 16, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 🤷🏻

@Wumpf Wumpf merged commit e0146e5 into main Jul 16, 2024
32 of 33 checks passed
@Wumpf Wumpf deleted the andreas/nightly-ci-fix-attempt branch July 16, 2024 13:36
Wumpf added a commit that referenced this pull request Jul 29, 2024
…environment

Similar to #6911
May fix Windows issues or at least make it easier to diagnose
Wumpf added a commit that referenced this pull request Jul 29, 2024
…environment

Similar to #6911
May fix Windows issues or at least make it easier to diagnose
jleibs pushed a commit that referenced this pull request Jul 29, 2024
…environment (#7009)

### What

Similar to #6911
May fix Windows issues or at least make it easier to diagnose


### Checklist
* [x]  pass main ci

- [PR Build Summary](https://build.rerun.io/pr/7009)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants