Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 390 conversations cypress to pytest #468

Merged
merged 12 commits into from
Dec 14, 2022

Conversation

cyplas
Copy link
Collaborator

@cyplas cyplas commented Dec 5, 2022

Detailed information:

  • transformed the conversation cypress e2e tests to pytest
  • tweaked the POST /conversation route to return 400 if json is not a dict

Closing issues:

List all issues the pull request solve:

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@cyplas cyplas linked an issue Dec 5, 2022 that may be closed by this pull request
@cyplas cyplas requested a review from danmash December 5, 2022 20:00
@codecov-commenter
Copy link

Codecov Report

Base: 66.71% // Head: 67.96% // Increases project coverage by +1.24% 🎉

Coverage data is based on head (087e1c7) compared to base (ee6427e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #468      +/-   ##
===========================================
+ Coverage    66.71%   67.96%   +1.24%     
===========================================
  Files           81       81              
  Lines         2569     2569              
  Branches       313      313              
===========================================
+ Hits          1714     1746      +32     
+ Misses         828      796      -32     
  Partials        27       27              
Impacted Files Coverage Δ
app/conversations/routes.py 76.42% <100.00%> (+18.57%) ⬆️
app/conversations/utils.py 62.50% <0.00%> (+15.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cyplas cyplas force-pushed the GH-390-conversations-cypress-to-pytest branch from 3cb95d6 to 99ebbe4 Compare December 12, 2022 17:28
Copy link
Member

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danmash danmash merged commit d1a5535 into develop Dec 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the GH-390-conversations-cypress-to-pytest branch December 14, 2022 20:47
@danmash
Copy link
Member

danmash commented Dec 14, 2022

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cypress conversations.cy.js with PyTest integration test
4 participants