Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cypress conversations.cy.js with PyTest integration test #390

Closed
danmash opened this issue Oct 12, 2022 · 2 comments · Fixed by #468
Closed

Replace cypress conversations.cy.js with PyTest integration test #390

danmash opened this issue Oct 12, 2022 · 2 comments · Fixed by #468
Assignees
@cyplas
Labels
refactoring testing
Milestone
#1 Replace Cypres...

Comments

@danmash
Copy link
Member

danmash commented Oct 12, 2022

What should be tested?

Replace e2e cypress tests from cypress/e2e/conversations.cy.js with PyTest integration tests.
@danmash danmash moved this to 📋 Backlog in Climate Mind Web App Oct 18, 2022
@danmash danmash moved this from 📋 Backlog to To do in Climate Mind Web App Oct 18, 2022
cyplas pushed a commit that referenced this issue Oct 22, 2022
#390 removed duplicate cypress test
8d37fdb
cyplas pushed a commit that referenced this issue Oct 22, 2022
#390 replaced empty conversations test with pytest
fad8f8a
cyplas pushed a commit that referenced this issue Oct 22, 2022
#390 lint
5bb539c
cyplas pushed a commit that referenced this issue Oct 22, 2022
#390 transformed invalid invitee name tests
71ccd16
cyplas pushed a commit that referenced this issue Oct 22, 2022
#390 transformed invalid session id test
42caf3d
@cyplas cyplas moved this from To do to 🏗 In progress in Climate Mind Web App Oct 22, 2022
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 removed duplicate cypress test
5cdcc6a
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 replaced empty conversations test with pytest
e288b73
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 lint
a64979c
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 transformed invalid invitee name tests
7de3de3
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 transformed invalid session id test
20a20d5
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 transformed single successful conversation creation
6ed3bbd
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 transformed conversations test with multiple conversations
868f2ab
cyplas pushed a commit that referenced this issue Oct 24, 2022
#390 lint
8cfdebc
@danmash
Copy link
Member Author

danmash commented Nov 21, 2022

@cyplas let me know if you need any help on this

cyplas pushed a commit that referenced this issue Dec 5, 2022
#390: added final test and tweaked route implementation
58c5776
@cyplas
Copy link
Collaborator

cyplas commented Dec 5, 2022

@cyplas let me know if you need any help on this

@danmash I was a bit stuck on one test, as I couldn't figure out how the cypress test claimed to be returning 400 (https://github.com/ClimateMind/climatemind-backend/blob/develop/cypress/e2e/conversations.cy.js#L216) when my python equivalent was returning 500, as https://github.com/ClimateMind/climatemind-backend/blob/develop/app/conversations/routes.py#L64 yielded an AttributeError. But in the end I just tweaked the implementation of the route to check that the json is a dict, which makes the tests match and (if you agree) is better anyway.

cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 removed duplicate cypress test
e61305f
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 replaced empty conversations test with pytest
28b8b5a
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 lint
32e99f6
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 transformed invalid invitee name tests
a3f48e5
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 transformed invalid session id test
1e5277f
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 transformed single successful conversation creation
5817c84
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 transformed conversations test with multiple conversations
0d67f9c
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390 lint
f66764b
cyplas pushed a commit that referenced this issue Dec 5, 2022
#390: added final test and tweaked route implementation
e6e6523
@cyplas cyplas mentioned this issue Dec 5, 2022
Merged
4 tasks
@cyplas cyplas linked a pull request Dec 5, 2022 that will close this issue
Gh 390 conversations cypress to pytest #468
Merged
4 tasks
cyplas pushed a commit that referenced this issue Dec 6, 2022
#390: removed obsolete cypress function
3cb95d6
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 removed duplicate cypress test
f9df308
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 replaced empty conversations test with pytest
1417fb3
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 lint
4475612
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 transformed invalid invitee name tests
c863406
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 transformed invalid session id test
df22e0a
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 transformed single successful conversation creation
4eb1ce2
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 transformed conversations test with multiple conversations
0ae326c
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390 lint
328d8bd
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390: added final test and tweaked route implementation
239694c
cyplas pushed a commit that referenced this issue Dec 12, 2022
@cyplas
#390: removed obsolete cypress function
42e51fd
cyplas added a commit that referenced this issue Dec 12, 2022
@cyplas
#390: removed duplicate uuid validation function
99ebbe4
danmash pushed a commit that referenced this issue Dec 14, 2022
@cyplas
Gh 390 conversations cypress to pytest (#468)
d1a5535 
* #390 removed duplicate cypress test

* #390 replaced empty conversations test with pytest

* #390 lint

* #390 transformed invalid invitee name tests

* #390 transformed invalid session id test

* #390 transformed single successful conversation creation

* #390 transformed conversations test with multiple conversations

* #390 lint

* #390: added final test and tweaked route implementation

* lint

* #390: removed obsolete cypress function

* #390: removed duplicate uuid validation function

Co-authored-by: Cyprian Laskowski <cyp@cjvt.si>
Repository owner moved this from 🏗 In progress to ✅ Done in Climate Mind Web App Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyplas cyplas

Labels
refactoring testing
Projects
Climate Mind Web App
Archived in project
Milestone
#1 Replace Cypress JS tests with PyTest
Development

Successfully merging a pull request may close this issue.

Gh 390 conversations cypress to pytest ClimateMind/climatemind-backend
2 participants
@danmash @cyplas