Validation check limit for precip raised to 3000 mm #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates validation step so that precipitation values up to 3000 mm are considered valid. This update comes bumping the validation/QC template to use the `dodola:0.15.0` container image.
|
Not sure why I poked you for the review, Emile. Sorry about that. Heads up to @dgergel that we're raising the precip validation ceiling up to 3000 mm with this dodola upgrade. |
|
@brews no that was useful. I have a hard time keeping track of all the moving pieces and this helps. Also it made me look at the release info and actually realize how poor my descriptions of ClimateImpactLab/dodola#163 were. |
|
👍 @emileten, no sweat! I'd say folk usually develop an eye for that kind of documentation as you get more experience and you are quickly getting experience! |
|
thanks for the heads up @brews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates validation template so that precipitation values up to 3000 mm are considered valid. The previous limit was 2000 mm.
This update comes with bumping the validation/QC template to use the new
dodola:0.15.0container image.