floor and ceiling for DTR

[emileten]

• helps closing (but does not close) :

• #468, #470, #472, #473, #474, #475, #476, #477, #481 from https://github.com/ClimateImpactLab/downscaleCMIP6/issues

• tests added / passed

• docs reflect changes

• entry in CHANGELOG.md

• rename the DTR correction core function to 'floor...'

• added an equivalent one for a ceiling only applied to [-60, 60]. Default ceiling is 70.

• merged these two functionalities in one service renamed to correct_dtr

• added tests for the latter

• accordingly modified click

• changed < to <= in the DTR range validation

This means our DTR 'validation' looses its meaning from when the DTR correction is applied on. It's a quick-and-dirty fix.

@dgergel this is just applying a cap at 70. This follows what I saw in the data (data points away from 60th north parallel but with a value significantly larger than 70) and me realizing (1) that 60th north parallel already crosses a significant european population area and (2) 70 diff in kelvin is already quite extreme

[brews]

So we can keep track of it, can someone list out the downscaleCMIP6 issues this is related to? This will create links and it will be easier to keep track of what needs to be rerun.

I see ClimateImpactLab/downscaleCMIP6#476. What else?

Edit:
Also, I'd be careful because this doesn't fully close the issues upstream in downscaleCMIP6. This is an upgrade we need, but we won't actually close it until we upgrade the Argo Workflows and container images in downscaleCMIP6 to take advantage of these new dodola features, @emileten.

[brews]

@emileten I think this looks good. I have two quick comments/suggestions on expanding documentation. Aside from these, I think we can merge this and take things for a run. Thanks!

[brews]

I took a look at this with a programmer's eye. @dgergel, I'd appreciate it if you could review this and double-check the method actually does what you want/described.

[dgergel]

@emileten this looks really good. Nice work!

My one suggestion for change - which should be really quick - is adding a correction_type argument to the CLI with options ceiling, floor or both (or something like that). Even though we're using dodola core functions in our workflow, since we're applying the ceiling and floor functionality at different points in the workflow, I think it'd be nice to have the option to only apply one here and have that be a service.

[emileten]

@dgergel @brews I addressed all your concerns and following our conversation, structurally modified things a bit.

floor and ceiling are two separate functions, in services and cli as well. That keeps things clean and there is no step when we're doing both.

@brews I am modifying the header of this to include all related issues.

[dgergel]

LGTM!

[brews]

@emileten Technically, I think this revision is fine (good, fast turn-around on this!). The changelog and PR description are a bit terse, but that's a minor comment given the deadline you're under for this.

[brews]

@emileten BTW, I think you can merge this whenever you're ready!