-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add post-downscaling wet day correction in the workflows #352
add post-downscaling wet day correction in the workflows #352
Conversation
…he correct_wetday_frequency param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brews is this needed to run a "correct" |
@brews I think I fixed one problem with this, not sure it was all or even part of what you were worried about. Back then I added the So, the few commits above I think should fix this. |
…nto pipeline_wet_day_post_correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate this contribution, @emileten ! I think this is good to go. 👍
I'm going to merge this and begin testing now that we've got some precipitation data to play with from #485. |
@brews I went ahead and added changes to make use of the option developed here ClimateImpactLab/dodola#141. From the
biascorrectdownscale
template, I passed over the already existingcorrect-wetday-frequency
parameter onto theqplad
template, then within it towith-lat-chunks
and within it toapply-qplad
. At that point the value of the parameter is passed to theboolean
click
option--wet-day-post-correction
. How does this sound to you ? I was thinking about testing that in an actuale2e-pr
workflow run, but I wanted your input first.Also -- I think that's for @dgergel -- note this means there isn't an option to apply this correction only pre or only post downscaling, it arbitrarily does both. Is that ok ?