Fix 360 day calendar conversion chunk errors from dodola.services.clean_cmip6 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brews thanks for that. So, I was going for either the option I chose, or this option. I chose the wrong one 😄 But now that I re-think about it, loading into memory is not 'costly' at all in terms of performance, rather the opposite. Provided we have the capacity to do that, it's fine. Right? Whereas rechunking is very expensive. |
emileten
approved these changes
Dec 9, 2021
This was referenced Dec 9, 2021
This was referenced Feb 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves chunking errors by loading the input Dataset into memory before cleaning/standardizing.
Close #149