Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xclim_convert_360day_calendar_interpolate does not support data chunked across time #149

Closed
emileten opened this issue Dec 9, 2021 · 0 comments · Fixed by #151
Closed

xclim_convert_360day_calendar_interpolate does not support data chunked across time #149

emileten opened this issue Dec 9, 2021 · 0 comments · Fixed by #151
Assignees
@emileten

Comments

@emileten
Copy link
Contributor

emileten commented Dec 9, 2021

This bug was introduced by #144. We're passing to xclim_convert_360day_calendar_interpolate an array of which the time dimension is chunked, while interpolation happens over that dimension. Tests didn't detect that because they do not test with chunking I think.

As a solution, we can either allow automatic rechunking or manually rechunk within xclim_convert_360day_calendar_interpolate to have a single time chunk and then the output gets rechunked anyways at exit.

Error pasted here ClimateImpactLab/downscaleCMIP6#436.
@emileten emileten self-assigned this Dec 9, 2021
@emileten emileten changed the title xclim_convert_360day_calendar_interpolate fails does not support data chunked across time xclim_convert_360day_calendar_interpolate does not support data chunked across time Dec 9, 2021
@emileten emileten mentioned this issue Dec 9, 2021
Closed
@emileten emileten linked a pull request Dec 9, 2021 that will close this issue
rechunk along time dim before cal conversion #150
Closed
brews added a commit to brews/dodola that referenced this issue Dec 9, 2021
@brews
Fix 360 day calendar chunks
4254756 
Close ClimateImpactLab#149
@brews brews mentioned this issue Dec 9, 2021
Merged
@brews brews closed this as completed in #151 Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emileten emileten

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@emileten