Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and rename some parameters #155

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remove and rename some parameters #155

merged 1 commit into from
Dec 1, 2023

Conversation

nefrathenrici
Copy link
Member

@nefrathenrici nefrathenrici commented Dec 1, 2023

Closes #99
This is a good time to make breaking changes, since we will make a new minor release soon. Maybe #88 should be merged as well, not sure if those changes are still needed.

Once this is merged I will make a new issue to catalog breaking parameter changes.

Content

Rename

  • microph_scaling -> microph_scaling_evap
  • entr_tau -> entr_inv_tau
  • detr_tau -> detr_inv_tau

Remove Seifert and Beheng 2001 parameters (SB2001)

  • kc_SB2001
  • kr_SB2001
  • xstar_SB2001
  • ν_SB2001
  • A_phi_au_SB2001
  • a_phi_au_SB2001
  • b_phi_au_SB2001
  • τ_0_phi_ac_SB2001
  • c_phi_ac_SB2001

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2e981a) 94.19% compared to head (f9c05da) 94.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files           1        1           
  Lines         155      155           
=======================================
  Hits          146      146           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nefrathenrici nefrathenrici merged commit 0aae724 into main Dec 1, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable name changes
2 participants