-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable name changes #99
Comments
Thank you @charleskawczynski I was thinking the same thing. We should collect a bunch of breaking changes to Parameters and weigh in when the number is big enough to warrant the work to propagate the change throughout all the repos |
This is something we have already started in a Gsheet. See the clima-parameters slack. I don't want to post the link publicly here though |
Sorry for replying late! @odunbar why a separate spread sheet and not a github issue? Do you have a lot of the breaking changes parameters piled up there? I was hoping to change the above name and to merge #88 and do a breaking release soon(ish). Do you have anything else that could be merged within a week that would results in a breaking change? |
I guess as I've the link to this sheet elsewhere the privacy idea is somewhat out the window. Last year we asked all the groups to contribute their parameters, units, naming conventions, descriptions to a shared sheet. For sharing and editing it was the most convenient format at the time. I do not think it is something we need to keep up-to-date, but should act more as an archive/or starting point for most parameters that are (likely) already in the ClimaParameters list. I expect as every parameter used to be called like Nothing should affect your current change. |
I replaced microphysics SB2001 scheme by SB2006 which expands SB2001 by more equations. As a result, the parameters of SB2001 are now redundant. I'd like to remove the following list of parameters in the next breaking release:
|
I would like to change |
Thank you! |
This issue is meant to track variable name changes that we'd like to make. Since changing variable names involves releasing a breaking version, which requires propagating through many packages, it makes sense to apply these changes in batches to avoid excessive work.
Here is a list of names we'd like to change:
microph_scaling
->microph_scaling_evap
cc @trontrytel
The text was updated successfully, but these errors were encountered: