Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding parameters of the double-moment microphysics scheme of Seifert and Beheng (2006) #107

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Adding parameters of the double-moment microphysics scheme of Seifert and Beheng (2006) #107

merged 1 commit into from
Mar 29, 2023

Conversation

sajjadazimi
Copy link
Member

Purpose

Adding parameters of the double-moment microphysics scheme of Seifert and Beheng (2006)

@codecov
Copy link

codecov bot commented Mar 26, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (ec9e3e4) 94.26% compared to head (666b14a) 94.26%.

❗ Current head 666b14a differs from pull request most recent head f1b63cf. Consider uploading reports for the commit f1b63cf to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   94.26%   94.26%           
=======================================
  Files           1        1           
  Lines         122      122           
=======================================
  Hits          115      115           
  Misses          7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sajjadazimi sajjadazimi force-pushed the sa/add_Microphysics_SF2006_parameters branch from 666b14a to 0bc7b76 Compare March 26, 2023 00:01
@sajjadazimi sajjadazimi force-pushed the sa/add_Microphysics_SF2006_parameters branch 2 times, most recently from 8af0795 to e212bec Compare March 26, 2023 00:23
@trontrytel
Copy link
Member

LGTM! The only comment is that if you are deleting the parameters, then technically it should be a "breaking" release (so v0.8.0 instead of v0.7.3). The reason is that the patch release will be automatically updated across all the repos and CIs, but if the parameter is suddenly not there it could break the CIs.

Doing a breaking release for CliMA Parameters is a huge hassle, because everything depends on them and we would have to update the dependencies everywhere. So I would suggest keeping the SB2001 parameters and just adding the SB2006 parameters. This way we can just do a patch release and nothing should be broken.

Could I then just ask you to add them to the pileup here: #99 So that when we finally get enough momentum to do a breaking release we will delete them?

trontrytel
trontrytel approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest avoiding deleting the old parameters - see my comment in the discussion.

@sajjadazimi sajjadazimi force-pushed the sa/add_Microphysics_SF2006_parameters branch from e212bec to f1b63cf Compare March 29, 2023 00:59
@sajjadazimi
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2023

Build succeeded:

@bors bors bot merged commit ed435ae into main Mar 29, 2023
@bors bors bot deleted the sa/add_Microphysics_SF2006_parameters branch March 29, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sajjadazimi @trontrytel