-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immersed boundary condition instead of forcing #130
Closed
Closed
Changes from all commits
Commits
Show all changes
784 commits
Select commit
Hold shift + click to select a range
8599005
Merge branch 'main' into ss/omip-simulation
simone-silvestri 7d5f10f
updating Oceananigans
simone-silvestri 15acee3
small bugfix
simone-silvestri 437d6e9
new compact
simone-silvestri f5eeff9
bugfix
simone-silvestri 029b3b4
might be right now
simone-silvestri 09f298d
start without near global omip
simone-silvestri c3498f4
fix ecco test
simone-silvestri 470c65e
another bugfix
simone-silvestri 7f74a6a
Update src/OceanSeaIceModels/CrossRealmFluxes/roughness_lengths.jl
simone-silvestri bd710fc
Update src/OceanSeaIceModels/CrossRealmFluxes/tabulated_albedo.jl
simone-silvestri 881b5b0
Update src/OceanSeaIceModels/CrossRealmFluxes/tabulated_albedo.jl
simone-silvestri 21a3e2c
correct typo
simone-silvestri 3f7149a
Update src/OceanSeaIceModels/ocean_only_model.jl
simone-silvestri 03533f4
TemperatureDependentAirViscosity and ReynoldsScalingFunction
simone-silvestri 454f85b
Merge branch 'ss/omip-simulation' of github.com:CliMA/ClimaOcean.jl i…
simone-silvestri 5ac8c83
update ScalarRoughnessLength
simone-silvestri 28eb46c
correct FT in albedo
simone-silvestri a1f3669
bugfix
simone-silvestri 1202a84
bugfix
simone-silvestri 3d6bb8f
FT for tabulated albedo
simone-silvestri 03f35ce
using zstar
simone-silvestri 74190cb
small bugfix
simone-silvestri c9824ab
Merge branch 'ss/omip-with-restoring' of github.com:CliMA/ClimaOcean.…
simone-silvestri 8859c50
bugfix
simone-silvestri 2625a04
another try
simone-silvestri 688eb57
better default for ECCOMetadata
simone-silvestri 4e96e69
some initial comments
simone-silvestri d3138c3
exposing al parameters
simone-silvestri a187d81
better stability functions
simone-silvestri 366d564
bugfixes
simone-silvestri d2f5e82
bugfixxed
simone-silvestri 988f8f2
some refactoring + adding flux examples
simone-silvestri 4a0164f
some grammar improvements
simone-silvestri 0c35023
bugfix in docs
simone-silvestri 6a43a52
Merge remote-tracking branch 'origin/ss/omip-simulation' into ss/omip…
simone-silvestri 6a53bf5
remove useless file
simone-silvestri 50fe313
bugfix
simone-silvestri 5862a0a
functions for time quantities
simone-silvestri ebf14fe
bottom drag coefficient
simone-silvestri 103b504
back to reference height
simone-silvestri 7d4eb0e
some improvements
simone-silvestri 8c165b9
bugfix
simone-silvestri 34b6265
revert to chloride
simone-silvestri c5babb7
changed pipeline
simone-silvestri 215b692
use github documenter for the moment
simone-silvestri a1ce58b
bugfix
simone-silvestri 31add81
change measurement to reference
simone-silvestri df0456e
conversion depending on k
simone-silvestri beaeacf
change to the
simone-silvestri f235888
change name
simone-silvestri f3487d9
bugfix
simone-silvestri c695266
namechange
simone-silvestri 8473926
add surface flux tests
simone-silvestri 2a6b1a4
change name to "gusty" velocity difference
simone-silvestri 36a3e17
typo
simone-silvestri 29993f6
bugfix
simone-silvestri 24a551c
correctly include runoff in forcing
simone-silvestri f1099d9
bugfix
simone-silvestri a0682f0
speed up generate fluxes
simone-silvestri 4f1f75e
Merge remote-tracking branch 'origin/ss/omip-simulation' into ss/omip…
simone-silvestri fc53863
error in project
simone-silvestri 26b8dee
ok found the issue!
simone-silvestri 8de82f2
Merge branch 'ss/omip-with-restoring' of github.com:CliMA/ClimaOcean.…
simone-silvestri e1f386d
correct the functions
simone-silvestri 0309ddd
change to z_data
simone-silvestri 2378460
improve example
simone-silvestri f9ba0ca
closure
simone-silvestri bf8e2e8
Merge remote-tracking branch 'origin/main' into ss/omip-with-restoring
simone-silvestri 05e4c0e
extrinsic-intrinsic
simone-silvestri 7fed375
remove interpolate
simone-silvestri 88bd8fd
z_data instead of h_data
simone-silvestri 4f459e0
add warning for longitude range
simone-silvestri 662552c
small change
simone-silvestri 2914348
Merge branch 'ss/some-fixes' into ss/omip-with-restoring
simone-silvestri baa271b
change the CFL
simone-silvestri 2b82a95
comments
simone-silvestri aa25de7
remove zstar prototype
simone-silvestri d4a2715
bugfix
simone-silvestri 9aa92e6
Merge branch 'main' into ss/omip-with-restoring
simone-silvestri 4268b5d
small bugfix
simone-silvestri 731ad73
Merge branch 'ss/omip-with-restoring' of github.com:CliMA/ClimaOcean.…
simone-silvestri 5c98a49
Merge remote-tracking branch 'origin/main' into ss/omip-with-restoring
simone-silvestri 3cfcf5a
bugfix
simone-silvestri 122dfd3
allow precompilation
simone-silvestri 559ab98
small bugfix
simone-silvestri 5582b14
change default to ecco2daily
simone-silvestri 6559e96
correct JRA55
simone-silvestri 66afab0
remove one division
simone-silvestri 4bced96
some optimizations
simone-silvestri e015701
let's see if this speeds up the computation
simone-silvestri bf340cc
updating catke to new syntax
simone-silvestri 00a9ecc
also new manifest
simone-silvestri d5279a1
add on_architecture
simone-silvestri f2eca7f
the conversion is done _inside_ fts
simone-silvestri 1f2582e
another try
simone-silvestri 8dc34cc
small verification
simone-silvestri d5e0797
fix a typo
simone-silvestri e91d270
typo
simone-silvestri 8198689
last try
simone-silvestri 8c5ce3f
another bugfix
simone-silvestri 2bb12b4
another bugfix
simone-silvestri 4089fdc
fix back
simone-silvestri 2e2ea63
back to square one. Still very slow
simone-silvestri 3add473
switching to an array
simone-silvestri dfe9ba6
some changes to the docstring
simone-silvestri c6a726d
bug with reciprocal of rho
simone-silvestri 7fc9554
more fixes
simone-silvestri aa17c4e
switch reference frames
simone-silvestri 1a460b2
try fixing tests with secret tokens
simone-silvestri 65327db
take ecco 4 monthly
simone-silvestri 35a086c
maybe here it will work?
simone-silvestri e8b3396
userame and password in docs
simone-silvestri d899b48
Merge remote-tracking branch 'origin/main' into ss/omip-with-restoring
simone-silvestri 738aac0
ecco secrets in ci
simone-silvestri e5aee9f
Merge branch 'main' into ss/omip-with-restoring
simone-silvestri ac42848
remove all ECCO2 from examples
simone-silvestri ec0445d
Merge branch 'ss/omip-with-restoring' of github.com:CliMA/ClimaOcean.…
simone-silvestri a297bf9
more verbose error
simone-silvestri d691f3b
test new buildkite env variables
simone-silvestri da0aeab
fix tests
simone-silvestri 98881ff
fix tests
simone-silvestri ecdad34
fix tests
simone-silvestri 0392145
some fixes
simone-silvestri 9caf8af
Merge branch 'main' into ss/omip-with-restoring
simone-silvestri 0796fab
the simulation that is running
simone-silvestri aacd2e1
Merge branch 'ss/omip-with-restoring' of github.com:CliMA/ClimaOcean.…
simone-silvestri 699958a
Merge branch 'main' into ss/omip-with-restoring
simone-silvestri e84613b
name changes
simone-silvestri 0d601f4
some changes to the simulation
simone-silvestri fb99d65
try it out
simone-silvestri 7dec068
test documentation on GPU
simone-silvestri d4d9c2f
correct docs key
simone-silvestri b09c835
timeout the docs after 24 hours instead of the default 2
simone-silvestri 3413721
med example on the GPU
simone-silvestri 841e487
update Oceananigans
simone-silvestri 13cc2f8
namechange to pipeline
simone-silvestri ddbe363
rename the examples build
simone-silvestri 5ef6fa7
remove size threshold
simone-silvestri 68bc957
GLMakie -> CairoMakie
simone-silvestri 03c9038
add GPUs
simone-silvestri 97c6661
yet another bugfix
simone-silvestri 6406bbc
yet another bugfix
simone-silvestri 2a9d613
test on Oceananigans#main
simone-silvestri 00b5571
test on Oceananigans#main
simone-silvestri a8da3c7
instantiate first
simone-silvestri f1d6dc9
Oceananigans#main
simone-silvestri 2e7d15b
smooth out a couple of bugs
simone-silvestri 7e4028f
Merge remote-tracking branch 'origin/main' into ss/documentation-on-c…
simone-silvestri 565f4b3
remove Oceananigans from docs Project.toml
simone-silvestri 051e590
fix gpu problem
simone-silvestri f2a741d
try only the near global at the moment
simone-silvestri 57c2ca9
remove reaive humidity
simone-silvestri af4649a
remove reative humidity cause not used
simone-silvestri 74d48c0
bugfix
simone-silvestri 91dcf9d
just check the near global configuration
simone-silvestri d69ae9a
try with everything together
simone-silvestri 48269d6
typo
simone-silvestri edce55f
try without the giba simulation
simone-silvestri 908066b
simple cpu example
simone-silvestri f2f9d6b
adding a slurm time
simone-silvestri d375f0b
try with SSL_no_verify
simone-silvestri 7a7d0a3
try with wget
simone-silvestri ef8ca0a
typo
simone-silvestri a12ceee
full fledged model on GPU
simone-silvestri 6d6b0cc
Update .buildkite/examples_build.yml
simone-silvestri 40f75d3
add literate debug
simone-silvestri 3e9bdfc
back to previous project / manifest
simone-silvestri 836b94f
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri c88ea50
add visualization
simone-silvestri 23ddab5
check if it deploys
simone-silvestri 1f18b8e
test the deploy keys
simone-silvestri b15e3ac
test reading the ssh key
simone-silvestri ec7e027
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri 4f5550e
typo
simone-silvestri e81ef73
the docs deploy?
simone-silvestri 6008b79
check deployment again
simone-silvestri 87a1ad4
test docs deployment
simone-silvestri 447666e
remove `winthenv`
simone-silvestri 3b92297
near global simulation in docs
simone-silvestri b7c1713
better comments
simone-silvestri e3c4908
another test
simone-silvestri 297bacd
try new keys
simone-silvestri 2a6d7a9
progress it stuck on single_column_grid
simone-silvestri 8013eef
test only with snapshot
simone-silvestri 5df3f22
gif -> mp4
navidcy cf46b69
remove also "inspect_ecco_data.jl"
simone-silvestri 91e0139
try with a video?
simone-silvestri 4a007d9
print every 500 iterations
simone-silvestri 70f7c5e
max abs
simone-silvestri 7463008
some changes to simulation details
simone-silvestri 665e88d
smaller titles
simone-silvestri dc00749
lift correct variables
simone-silvestri b8a4d0b
reduce frames by a factor of two
simone-silvestri 45f1f91
Merge branch 'main' into ss/documentation-on-caltech
simone-silvestri 5f622a4
bugfix
simone-silvestri 52bb4df
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri 7f2936f
another bugfix
simone-silvestri 51ca046
adding generate bathymetry
simone-silvestri 91f3c5d
some bugfixes
simone-silvestri 6fcd1ce
better colormaps
simone-silvestri 9be7044
more massaging
simone-silvestri b0e95ac
try the full global ocean
simone-silvestri a6f80f5
global ocean simulation
simone-silvestri baaa569
Parameter space problem
simone-silvestri b89e12f
unfortunately we cannot use active cells map
simone-silvestri 638eb78
few tweaks
navidcy 34a1cfd
code cleanup
navidcy 365472b
code cleanup
navidcy 6f3982c
code cleanup
navidcy c818e52
clearer explanation
navidcy c61f648
clearer explanation
navidcy e2cae09
try the global ocean
simone-silvestri ea6453f
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri eead6e5
better visualizations
simone-silvestri 1691ffc
try again
simone-silvestri 34fc86b
Merge branch 'main' into ss/documentation-on-caltech
simone-silvestri 20468f8
fix bug
navidcy 32d25db
change figure size
simone-silvestri 826208d
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri e76f053
one movie per quantity
simone-silvestri 85c6872
Merge branch 'main' into ss/documentation-on-caltech
simone-silvestri 0cc5af0
bugfix
simone-silvestri eedc8b7
fix typo
simone-silvestri 21386db
some more bugfixes
simone-silvestri ec6ddd2
Merge remote-tracking branch 'origin/ss/bugfix' into ss/documentation…
simone-silvestri e72d56c
first small change
simone-silvestri 2cfa937
lakes -> connected regions
navidcy 832803f
warm up -> spin up
navidcy 906341e
add colorbars
navidcy d7afd8a
code alignment
navidcy 2696891
bugfix
simone-silvestri 1ed5af1
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri 62cde16
Merge branch 'main' into ss/documentation-on-caltech
simone-silvestri be69b32
Merge branch 'main' into ss/documentation-on-caltech
simone-silvestri 1418c46
some formatting changes
simone-silvestri 7672837
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri 3613f05
bugfix
simone-silvestri 92f2d9a
typo
simone-silvestri 7938345
bugfix
simone-silvestri a2a37fd
back to how it was
simone-silvestri 86e8517
fix precompilation issue
simone-silvestri ca6ce9b
Merge branch 'ss/documentation-on-caltech' of github.com:CliMA/ClimaO…
simone-silvestri 29defef
Update examples/near_global_ocean_simulation.jl
simone-silvestri 7056623
fix examples then merge
simone-silvestri 0c0ce6c
different unit of measure
simone-silvestri d13169d
add immersed drag
simone-silvestri 01c988c
trigger examples build
simone-silvestri 0d57448
Merge branch 'main' into ss/immered-boundary-condition
simone-silvestri 4d580c0
Merge branch 'main' into ss/immered-boundary-condition
simone-silvestri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only change I expected to see