Immersed boundary condition instead of forcing

[simone-silvestri]

To be merged only if the near-global example works with reasonable velocities

closes #128

[glwagner]

To be merged only if the near-global example works with reasonable velocities

closes #128

Why would it be different?

If its different there's a bug. We should also add a test to check for this this specifically in Oceananigans, since it has been discovered / is believed to be possible here.

[simone-silvestri]

The results here should tell us if this method works. A test in Oceananigans should definitely be added because it looks like this is untested

[glwagner]

Why do you think it is possible they are different? Have you seen this before? Is there another example where this occurred?

[simone-silvestri]

I remember some time ago there was a problem with this method, but I would have to go back to look at what issue it was.
I guess it has been solved. I am being cautious because now that we have a global simulation running we don't want to break it so it is always good to look

1. the wall time step per time step
2. the validity of the of the outputs

[glwagner]

I remember some time ago there was a problem with this method, but I would have to go back to look at what issue it was. I guess it has been solved. I am being cautious because now that we have a global simulation running we don't want to break it so it is always good to look

1. the wall time step per time step
2. the validity of the of the outputs

We shouldn't have to use such caution, because the code should not have so many bugs that things are so delicate. Can we figure out what the issue is? I don't think ImmersedBoundaryCondition has been developed lately. I'm not sure how the problem could have been solved.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (41aa1e4) to head (4d580c0).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/OceanSimulations/OceanSimulations.jl	0.00%	11 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #130   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         31      31           
  Lines       1740    1742    +2     
=====================================
- Misses      1740    1742    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[simone-silvestri]

Maximum velocity seems to be equal between this PR and the documentation one

https://clima.github.io/ClimaOceanDocumentation/previews/PR104/literated/near_global_ocean_simulation/
vs
https://clima.github.io/ClimaOceanDocumentation/previews/PR130/literated/near_global_ocean_simulation/

[glwagner]

This PR lists 29 files changed but the title just states that bottom drag was implemented with ImmersedBoundaryCondition vs Forcing. Why are so many files changed?

[simone-silvestri]

because we have to merge the documentation PR

[glwagner]

this is the only change I expected to see

[glwagner]

There are 783 commits on this PR

[glwagner]

Then put this PR to merge into that PR, not main

[simone-silvestri]

oops too late, I ve merged the documentation PR

[glwagner]

Still 784 commits here. Maybe open a new PR with just the changes needed here?

[glwagner]

@navidcy any idea why the preview for this isn't showing? Or where it might be?

[simone-silvestri]

Closed in favor of the new PR

[glwagner]

delete the branch?