Bugfixes #8545
Merged
Bugfixes #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare with game::update_map - the code in shift_monsters assumes that levx and levy already point to the *new* coordinates.
The increment is not supposed to happen there.
worldfactory: add proper initialization of pointer members, Simplified deconstructor, no need to clear the maps, they are deconstructed anyway. Also changes the modmanager pointer to be a smart pointer to let it handle its own destruction.
| optionNames["en"] = "English"; | ||
| optionNames["fr_FR"] = "français (France)"; | ||
| optionNames["de_DE"] = "Deutsch (Deutschland)"; | ||
| optionNames["it"] = "italiano"; |
There was a problem hiding this comment.
Needs more caps. I'll see what I can do.
Update: I don't have font support for Chinese, Japanese, or Korean, so can't speak for those. Sorry. All other languages are capitalized.
|
Don't worry. Chinese Japanese and Korean don't really have the concept of capitalization. The japanese one is correct though, I recognize that much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8540 (hopefully) - there is one iterator increment to much.
Fixes #8469 - language names taken from http://msdn.microsoft.com/en-us/goglobal/bb896001.aspx
Fixes #8307 - prevent accessing an empty dreams vector.
Fixes #8416 - remove unnecessary null pointer checks
About 4f40f7f: Compare with game::update_map - the code in shift_monsters assumes that levx and levy already point to the new coordinates. When debug teleporting only a single overmap tile away, the monster positions have been screwed because of this.