Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SW 617, Ruger PCC, Marlin 60 #79602

Merged
merged 6 commits into from
Feb 9, 2025
Merged

Conversation

Holli-Git
Copy link
Contributor

Summary

Content "Add in the guns S&W 617, Ruger PCC, and Marlin Model 60"

Purpose of change

These are some pretty common guns from the list, and also ones that I don't have to add any magazines for. These are also somewhat unique guns, as I don't yet have the patience to add in yet another 9mm handgun.

Describe the solution

Adds them.

Describe alternatives you've considered

Adding more. Or less. Maybe both?

Testing

Yup. Spawns aight.
image
image
image

Additional context

Here's from the list, and gunbroker just in case.
image
image

image
image

image
image

Yes I know that the list isn't completed, but these are all ranked in the 1000s and uncompressed so I'm confident it passes.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) labels Feb 8, 2025
@github-actions github-actions bot requested a review from I-am-Erk February 8, 2025 18:00
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Ruger PCC
  • Ruger PCCs
  • The Ruger PCC is a pistol caliber carbine, made by Ruger. It's quite commonplace, thanks to its low recoil, reliability, and use of readily available magazines.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 8, 2025
@Maleclypse Maleclypse merged commit 64a737c into CleverRaven:master Feb 9, 2025
28 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants