-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved] More seasonal magic #79592
Draft
Standing-Storm
wants to merge
13
commits into
CleverRaven:master
Choose a base branch
from
Standing-Storm:more-seasonal-magic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Xedra Evolved] More seasonal magic #79592
Standing-Storm
wants to merge
13
commits into
CleverRaven:master
from
Standing-Storm:more-seasonal-magic
+847
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved] More seasonal magic"
Purpose of change
The first PR had a ton of lines taken up with the system for gaining spells, so I only added a few spells for each season. However, a lot of things rely on how many spells per season you know, so each season needs more spells.
Describe the solution
Add the following spells:
SPRING
SUMMER
AUTUMN
WINTER
More to come.
Describe alternatives you've considered
Testing
WIP
Tested the following glamours and they work: Viridian Cuirass, New Growth, Quick-Kindle, Salmon’s Leap, Outracing the Sun, Footsteps in the Snow
Additional context