Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pronoun/pride pins #79572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Holli-Git
Copy link
Contributor

Summary

Content "Add in pride/pronoun pins"

Purpose of change

Pronoun and pride pins would be pretty cool to have.

Describe the solution

Adds in em.

Describe alternatives you've considered

Making separate itemgroups so multiple can spawn at once, but ehhh that'd require a fair amount of work to make sure redundancies and contradictions aren't super common.

Testing

Yup! Works aight.

Additional context

These aren't weighted at all, as the type of people who tend to wear pride/pronoun pins tend to skew more queer, so might as well go full hog with the inclusion.

@moxian
Copy link
Contributor

moxian commented Feb 7, 2025

Should these have dsitribution weights assigned to them? I imagine some would be a bit harder to find in the wild than others (especially in %current_year%+1 given the %current_year% political climate)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Items: Armor / Clothing Armor and clothing labels Feb 7, 2025
@Holli-Git
Copy link
Contributor Author

Should these have dsitribution weights assigned to them? I imagine some would be a bit harder to find in the wild than others (especially in %current_year%+1 given the %current_year% political climate)

No. I'd much rather have people in this climate recognize they're being seen and heard.

@Daved27hundred
Copy link
Contributor

Awesome!
Also I suggest taking some flags from the pride flag variants since there's a couple there not even I knew about.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 7, 2025
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 7, 2025
@Holli-Git
Copy link
Contributor Author

Awesome! Also I suggest taking some flags from the pride flag variants since there's a couple there not even I knew about.

Added in poly, labrys, and progress. Not too sure on adding the bear/leather one, no disrespect of course, just feels a bit out of place.

@LordBarkBread
Copy link
Contributor

Awesome! Also I suggest taking some flags from the pride flag variants since there's a couple there not even I knew about.

Added in poly, labrys, and progress. Not too sure on adding the bear/leather one, no disrespect of course, just feels a bit out of place.

We have Bear Pride Flag in already as a variant, not too sure how it would be out of place for pins as well.

@Holli-Git
Copy link
Contributor Author

We have Bear Pride Flag in already as a variant, not too sure how it would be out of place for pins as well.

I'm aiming to cover major sexualities/genders, and the bear one doesn't really match that. Yes, same could be said about the labrys flag, I'm still iffy on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants