Attach some debug info to release runner errors #79569
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Currently our release notes are broken (last good: cdda-experimental-2025-02-05-1708, first bad: cdda-experimental-2025-02-06-0250) for no apparent reason.
The runner logs are
unenlightening.
Somehow, the release notes work fine in my own fork (https://github.com/moxian/Cataclysm-DDA/releases)
(And also works fine locally. And also when i hackishly try it in a pull request )
Describe the solution
Add a tiny bit of context to the js errors. This does nothing to fix the issues, of course, but I have tepid hope that it might bring some light on what's going on at least
Describe alternatives you've considered
Idk, figure out what's happening and fix the root cause in one go.
Also, the classic: not do this.
I tried putting the context into
console.log()
but that one doesn't make its way into the CI log.I guess i could write
instead of what I'm doing right now, I don't think either is much better than the other. Lmk if you have strong opinions here.
Testing
Tried breaking it in a couple of ways. Got reasonably readable error out each time (
example - https://github.com/moxian/Cataclysm-DDA/actions/runs/13189583076/job/36819655541?pr=19
anoter example from an earlier version of the code - https://github.com/moxian/Cataclysm-DDA/actions/runs/13189397885/job/36819126328
Thinking more about it, I never got a literal
HttpError
we are seeing in CI right now, it has always beenHttpError: Something something
.Additional context
The
/releases/generate-notes
endpoint seems to require write permissions to the repo so I cannot really test that one locally for CleverRaven. (specifically the docs say it requires"Contents" repository permissions (write)
for "fine-grained tokens". I'm not sure what is the implication on the github actions runners).I suspect the fix would be addingto the yaml edit: If this is a new change that's github is slowly rolling out. And I can PR that. But idk if that's neccessary, and I'd much prefer to leave perms at default if that's an option...Late edit: nevermind, we already have
contents: write
permissions, as seen inSet up job
section of the runner log