Don't hardcode help text: Autopickup Manager

[Kilvoctu]

Summary

SUMMARY: Interface "Don't hardcode help text: Autopickup Manager"

Purpose of change

Help text should not be hardcoded as, if end user changes their keybinds, it will cause discrepancies in the UI.
This PR targets the autopickup manager and partially addresses #78986

Describe the solution

Pull the currently set keybind for each command, then replace the help text string with a function that enumerates the keybinds. Add one extra line for the help text.
Clean up the help text and leave just the autopickup toggle, and keybinds.

Describe alternatives you've considered

I initially wrote out a string for each line manually (can be seen in initial commit); however, there wasn't enough space, so I gave the help text a third line. Then I realized I can simply implement this the same as my previous PRs, which is cleaner imo.

2nd implementation kept all the help text, but there's still not enough space in the window when accounting for various circumstances as mentioned by moxian.
The help text area could change height to accomodate any amount of help text, but I'm feeling at that point the window is too bloated.

Testing

Game compiles and loads.
Look at autopickup manager on main menu.
Load world and look at autopickup manager.
Press all the command buttons.
Change the keybinds and see the text update.
Press all the new command buttons.

Additional context

The "switch" command after I changed the keybind to BACKSPACE

Earlier commit

Screenshot

After I changed a bunch of the keybinds. Still fits.

I realized after looking at these screenshots, the light gray lines on the outside border aren't lined up. Fixed now

[moxian]

The mismatch between the actual and displayed keybinds is obviously bad, so unhardcoding these is wonderful!

However, I'm not sure displaying all the keybinding on this screen is the correct approach in the face of translations.
We already have the keybinds listed in the [?] keybinds menu, we kinda don't want to create new translation strings when we have already translated them in the [?] menu (for translators workload sake), and as you note yourself the new layout is a bit tight and will be even tighter in other languages (for example german already has to abbreviate the hell out of them)

Even in English I suspect you can get out of bounds when you bind all those things to Insert/Home/PageUp/PageDn/Backspace.

I think it's better to remove all of them (except maybe the [s]witch one) and replace with a [?] Keybindings. (It's a much smaller and less impressive PR, granted, but is still an improvement over the current master IMO)

If you think that displaying all of them here (at the cost of extra translation work) is still better (which is valid!), then at the least we need to size the vertical space dynamically and not hardcode it to 3 lines (but that might be a bigger overhaul)

[Kilvoctu]

I think it's better to remove all of them (except maybe the [s]witch one) and replace with a [?] Keybindings. (It's a much smaller and less impressive PR, granted, but is still an improvement over the current master IMO)

If you think that displaying all of them here (at the cost of extra translation work) is still better (which is valid!), then at the least we need to size the vertical space dynamically and not hardcode it to 3 lines (but that might be a bigger overhaul)

Personally, I have no problems at all with just removing all the help text and leaving a [?] Keybindings. I've done it in the past, too #40236. I like clean UIs, no clutter lol.
I feel like, as you imply, anyone can simply open the keybinding screen if they need help.

There are three other similar "manager" windows (auto notes, safe mode, color), and it'd make things a lot simpler for everyone involved if we do it this way.

[Kilvoctu]

How does this look 🤔

Using the longest key I can think of for the command here

[moxian]

Not very good if I'm being honest.
True [BACKSPACE] Switch is hard to parse, and is somehow losing its context now that it's a bit visually further away from "Autopickup enabled"

Looking at this slimmer version, I feel that we don't need to display the switch keybind anymore (as in: the menu is not getting any less navigable if the keybind mention is gone).
If i hackishly remove it in paint, it looks okay to me:

I think if you can manage to put the [?] at the bottom of the screen, it would be better, but I don't feel too strongly about this one.
(And also, that time is probably better spent migrating the whole menu to ImGui 🙃 )