Dont show liquids from held or worn container in AIM [I]nventory-panel #79560
+21
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Dont show liquids from held or worn container"
Purpose of change
Having liquids show up as any other item in AIM leads to some weird behavior like #79559.
would fix #79559.
Describe the solution
Instead of making a special case for every action, I suggest not showing the content of held or worn containers from [I]nventory pane if it's liquid, since I don't see any use-case for liquids outside of the [c]ontainer pane.
Additionally move the liquid check outside the
dpane.get_area() == AIM_INVENTORY
check for move_all in case there is another way to have liquids show up in the inventory screen. If you want to move liquids to a container you can still use the (u)nload function in AIM.Describe alternatives you've considered
Add a query that the liquids will be spilled similar to [d]ropping liquids
Testing
When wielding or wearing a canteen of water you no longer see water in the inventory pane.
Additional context