Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Convert code to keep track of which map it operates on rather than (almost) always assume it's the reality bubble.
This time the focus was on changing the vehicle position to absolute rather than bubble coordinates relative to some undefined map (typically a local mapgen one or the reality bubble). Code sort of happened to work for some reason when mapgen maps were used to generate bubble ones.
Describe the solution
Convert a few vehicle operations, but mainly change the vehicle position data.
Describe alternatives you've considered
Spend additional effort trying to work around the need for map references. That was possible in a few cases (getting the absolute position, which gets what's stored, and thus doesn't need any map reference, to feed an operation that can take either an absolute or a bubble coordinate, such as getting a monster at a location). Thus far only easy cases have been spotted.
Testing
Running tests locally (a number of errors were shown before being found, including the one stumping me on an earlier attempt).
Play testing, i.e. a couple of hours of normal game play with a lot of driving around (and thus generation of vehicles on new maps) without seeing anything odd.
Additional context