Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an island-only sun protection to Sky island #79525

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

SariusSkelrets
Copy link
Contributor

Summary

Mods "Add an island-only sun protection to Sky island"

Purpose of change

Sun-sensitive characters burned under the sun even on the island.
Now they can craft an item that gives full sun protection as long as they're on the island but only while they're on the island.

Describe the solution

Add a recipe unlocked from the statue.
Making the recipe gives a mutation that gives an integrated armor while on the island.
said armor fully protects from the sun but doesn't do anything about other things.
The armor is removed while not on the island.

Describe alternatives you've considered

Expanding the fake air to make the entire island count as indoors, but I've been told that the cold wind is intended so I won't do something that would block it.

Testing

Became a naked vampire, burned under the sun.
Crafted the item, stopped burning.
Started an expedition, started burning again.
Came back, stopped burning.

Additional context

There is room for more upgrades like that, but the island must be the place between expeditions and not the main place, so they require caution when adding them to not undermine the gameplay loop.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Missions Quests and missions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Sky Island Anything about the Sky Island mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 3, 2025
@GuardianDll GuardianDll merged commit 99ffd7c into CleverRaven:master Feb 4, 2025
30 checks passed
@SariusSkelrets SariusSkelrets deleted the Sky_Island_Sunblock branch February 4, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants