Initial support for GNU Make for Windows #79500
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uname -o` is supported by gha macos-13.
They both inherit OS from Windows
github-actions
bot
added
Code: Build
github-actions
bot
added
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Initial support for GNU Make for Windows"
Purpose of change
https://github.com/maweil/CompileMakeForWindows provides executable and dll for GNU Make v4.
https://gnuwin32.sourceforge.net/packages/make.htm stopped a v3.81.
Describe the solution
Start moving some
$(shell ...)calls to be compatible withWindows under a Developer PowerShell for VS 2022.Describe alternatives you've considered
Wait to fully support MSVC, but it is a long way to go. Let's see what this PR breaks first.
Testing
uname -o: it is now supported on GH runnermacos-13Additional context
Hoping macOS builds, need to see how GHA reacts, hence Draft PR first