Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Rail Vehicles #79498

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

mx-moonling
Copy link
Contributor

Summary

Content "Adds new rails vehicles"

Purpose of change

The current rail vehicles are very large (7x17), and do not coexist well with the rail system we have. They derail frequently and ram into obstacles outside their overmap tile when turning.

Describe the solution

Adds a 7x12 train chassis for spawning and to allow other contributors an easier time building a new train car in the future.
Adds a 7x12 diesel locomotive.
Adds a 7x12 passenger car.
Adds a two more pairs of non steerable rail wheels to the 6 person draisine. Having some non steerable wheels seems to make it behave better.

I decided on a 7x12 layout because it allows for two passenger cars to be placed per map tile, and while still feeling very big and train sized, works well on the railroads.

Describe alternatives you've considered

Bringing the wheels on existing closer towards the center of the train. This allows the locomotive and passenger car to take turns, but leads to having a very large overhang on either side, which smash into many obstacles even above ground, and seem weird.
Finding a way to expand the zone cleared out by subway and railroad generation.

Testing

Made a new world, drove around on the surface with the new diesel locomotive, had no collisions with trees or buildings.
Still doesn't work in the subway, the locomotive rams into the stone walls, but I believe this can be fixed by expanding within the subway curve tile.

If you want to test driving around, rotate the train in the direction you want to go before entering a junction. Attempting to change the angle you're driving while within a junction seems to almost always cause a derailment.

Additional context

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant