Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move surface rail lines closer and add junctions #79481

Merged
merged 9 commits into from
Feb 2, 2025

Conversation

mx-moonling
Copy link
Contributor

Summary

Mods "Moves the rail lines used by the railroad mapgen closer and adds junctions"

Purpose of change

The first pass implementation of railroads in #67713 did not include actual junctions in the tiles where multiple tracks met, which made the railroads unable to be navigated by trains. The tracks were also moved further apart compared to the subway system, with no justification I could find.

Describe the solution

The surface railroad had a larger gap between the two train lines than the subway. This made curves tighter, and junctions much harder to build within a single maptile. It also made working on rail vehicles harder, because a vehicle that runs well on the surface might derail underground, or vice versa.

Adapted the straight and curved subway maptiles for use on the surface, copying them from the c++ into json and changing some of ground tiles used.
Modified the 4 way maptile, replacing the half wood & half rail diagonals with full rail.
Modified the 4 way to be a functional 3 way, instead of using the semi functional 3 way from the subway.
Went over the bridge and railroad crossing, and brought them in line with the new rail system.

Describe alternatives you've considered

Leaving the sets of tracks further apart, and attempting to build junctions within the tighter constraints.

Testing

Entered a new world with the railroad mod, checked that everything lined up.
Drove around in a two and six person draisine, as well as an electric train.
The two person draisine worked like a dream, no issues.
The six person draisine & electric train had the odd habit of hopping onto the other track on tight curves, or derailing, but this happened less compared to the previous system. I also found that adding more rail wheels to the six person draisine, and moving the wheels closer together on the electric train, seemed to fix all the issues (which I will work on implementing and testing in another PR).

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 1, 2025
@Maleclypse Maleclypse merged commit ce64b59 into CleverRaven:master Feb 2, 2025
29 of 30 checks passed
@mx-moonling mx-moonling deleted the move-rail-lines-closer branch February 2, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants