Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some missing flags to allow better mapgen control #79474

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

juur
Copy link
Contributor

@juur juur commented Feb 1, 2025

Summary

Content "Add some missing flags to map_extras"

Purpose of change

Whilst playing around with generating the most boring maps possible (i.e. disabling all lore etc.) I found I was still getting some content, I resolved this by adding some missing flags, such that they be used e.g. below:

[
  {
    "type": "region_overlay",
    "regions": [ "all" ],
    "overmap_feature_flag_settings": {
      "clear_blacklist": true,
      "blacklist": [
        "ANT", "BEE", "BLOB", "CLASSIC", "CITY_UNIQUE", "EXODII", "FARM",
        "GLOBALLY_UNIQUE", "OVERMAP_UNIQUE", "FUNGAL", "LAB", "MAN_MADE",
        "MI-GO", "MILITARY", "SLIME", "TRIFFID", "UNIQUE", "URBAN",
        "YRAX", "WASP", "SPIDER", "PORTAL"
      ],
      "clear_whitelist": true,
      "whitelist": [  ]
    }
  }
]

Describe the solution

Add some extra flags to overmap/map_extras.json so they can be filtered.

Describe alternatives you've considered

Do nothing.

Testing

Create a simple mod, with config above, spawn: yay no huge bees.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 1, 2025
@RenechCDDA
Copy link
Member

Sorry, I'm not really... seeing the point here? Mods can already set the weights on these to 0, or override them as desired. What are these flags actually accomplishing? Especially e.g. "BEE", which is added to exactly one piece of mapgen.

@juur
Copy link
Contributor Author

juur commented Feb 1, 2025

Sorry, I'm not really... seeing the point here? Mods can already set the weights on these to 0, or override them as desired. What are these flags actually accomplishing? Especially e.g. "BEE", which is added to exactly one piece of mapgen.

I didn't know about weights. Are there any good examples?

If someone was to add a second mapgen with bees in it, wouldn't the mod require an update to set the weight to 0, whereas if it was flagged via "BEE" it is more future-proof?

A related question - what purpose do the existing flags serve? e.g. EXODII or LAB ?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 1, 2025
@GuardianDll
Copy link
Member

blacklist flags exist because we expect this type of stuff being expanded in the future, like EXODII flag; there is little benefit of adding this flags to a unique locations
from other side, we already have some of this flags, like BEE; desert region mod also blacklists WASP maps, even if we do not have any in the game yet
Yeah i think this is fine

@GuardianDll GuardianDll merged commit 3dfe45d into CleverRaven:master Feb 2, 2025
30 checks passed
@juur juur deleted the map_extra_missing_flags branch February 2, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants