Update Cataclysm.sh #79472
Closed
Update Cataclysm.sh #79472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bash Shebang: Changing to #!/bin/bash ensures that Bash-specific features work as expected. Robust Directory Handling: The script now checks whether the cd command succeeds and aborts with an error message if it fails. Dynamic Environment Exports: The exports for the dynamic library and framework paths are performed both for the current shell (for the tiles version) and included in the new Terminal command (for the non-tiles version). Executable Checks: Added an elif to verify that cataclysm-tiles exists, with an error output if neither executable is found. Improved Command String: The Terminal launch command now wraps paths in quotes and includes the necessary exports so that the new shell session has the proper environment.
github-actions
bot
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash Shebang: Changing to #!/bin/bash ensures that Bash-specific features work as expected.
Robust Directory Handling: The script now checks whether the cd command succeeds and aborts with an error message if it fails.
Dynamic Environment Exports: The exports for the dynamic library and framework paths are performed both for the current shell (for the tiles version) and included in the new Terminal command (for the non-tiles version).
Executable Checks: Added an elif to verify that cataclysm-tiles exists, with an error output if neither executable is found.
Improved Command String: The Terminal launch command now wraps paths in quotes and includes the necessary exports so that the new shell session has the proper environment.
Summary
Category "Brief description"
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context