Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character randomization sometimes produces 'crossdressing' characters #76812

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

RenechCDDA
Copy link
Member

@RenechCDDA RenechCDDA commented Oct 4, 2024

Summary

Features "Character randomization sometimes produces 'crossdressing' characters"

Purpose of change

While examining the new character code I noticed that character randomization always locked the outfit gender to actual gender. Not all people wear clothes considered typical for their gender, so this is a strange omission.

Describe the solution

Give it a 10% chance to give the randomized character a different gender's outfit.

Character templates will properly save the outfit gender and re-apply it when that template is used again

Describe alternatives you've considered

I was just going to make it 50/50 on the outfit but that was TOO GAY. This is only moderately gay.

Testing

Randomizing sometimes gives other gender outfits:

2024-10-04.12-33-11.mp4

Outfit gender is properly saved with character template:

2024-10-04.12-34-11.mp4

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 4, 2024
@RenechCDDA
Copy link
Member Author

Oops, accidentally pulled the proposed patch for #76808. But hey, it seems to work so nothing wrong with gaying it up some more.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 4, 2024
@kevingranade kevingranade merged commit 34aab02 into CleverRaven:master Oct 4, 2024
26 of 30 checks passed
@RenechCDDA RenechCDDA deleted the gay_it_up branch October 5, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outfit gender is not saved in characte template
4 participants