Removed POLEARMS weapon category from big number of weapons in spears_and_polearms.json #76590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Looks like there is big misunderstanding about which weapons should be in
POLEARMS
weapon category. According to the commentCataclysm-DDA/data/json/requirements/melee.json
Line 645 in 6805e26
pikes shouldn't have
POLEARMS
weapon category, since they are made for stabbing and not for slashing. Thus many weapons inspears_and_polearms.json
erroneously have this weapon category, like all types of pikes, spears, and javelins.Describe the solution
Removed
POLEARMS
weapon category from big number of weapons inspears_and_polearms.json
, made all types of pikes haveSPEARS
category instead ofPOLEARMS
.Also changed weapon category from
FENCING_WEAPONS
toSPEARS
forsharpened pipe
. I think that weapon category was just a mistake, but I might be completely wrong on that.Describe alternatives you've considered
None.
Testing
None, obvious json change.
Additional context
None.