Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed POLEARMS weapon category from big number of weapons in spears_and_polearms.json #76590

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

None

Purpose of change

Looks like there is big misunderstanding about which weapons should be in POLEARMS weapon category. According to the comment

"//": "Any real, top-heavy cutting weapons with a long pole and a blade on the end, designed to swing side-to-side. Think like a sword with a really long handle.",

pikes shouldn't have POLEARMS weapon category, since they are made for stabbing and not for slashing. Thus many weapons in spears_and_polearms.json erroneously have this weapon category, like all types of pikes, spears, and javelins.

Describe the solution

Removed POLEARMS weapon category from big number of weapons in spears_and_polearms.json, made all types of pikes have SPEARS category instead of POLEARMS.
Also changed weapon category from FENCING_WEAPONS to SPEARS for sharpened pipe. I think that weapon category was just a mistake, but I might be completely wrong on that.

Describe alternatives you've considered

None.

Testing

None, obvious json change.

Additional context

None.

…rs_and_polearms.json

Made all types of pikes have SPEARS category instead of POLEARMS.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 21, 2024
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 21, 2024
@Maleclypse Maleclypse merged commit d5abeca into CleverRaven:master Sep 22, 2024
24 checks passed
@Night-Pryanik Night-Pryanik deleted the pike branch September 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polearm proficiences are inconsistent
2 participants