-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete and migrate legacy wire #76204
Conversation
Testing: As well as you can. Some ideas:
|
Should I keep the |
How broadly should the "any_wire" requirement group be used? Currently they're used in every recipe involving wire where the wire grade does not matter (anything like space heaters, wooden wheel mounts, canteens, vehicle controls, butchering racks...). However mild steel wire is indeed easier to work and weld, and the material properties of different wire grades are different. So the alternative is to only allow mild steel wire, which makes it very commonly used, but makes other wire grades harder to use, which may be a non-issue. |
Should it migrate in-progress items or such migrations are not implemented? |
I'm not aware of any ways of doing that, no. |
Summary
Balance "Obsolete and migrate legacy wire in favor of mild steel wire"
Purpose of change
Closes #75840. Legacy steel should be discontinued and split instances of
wire
andlc_wire
should be unified.Describe the solution
Migration and item handling
Mass replace
"wire"
with"lc_wire"
.Create a migration for
wire
tolc_wire
.Create a migration for piano wire to
qt_wire
.Create an
"any_wire"
requirement group that contains all wires (except legacy wire). Include it in appropriate places.Constructions
All constructions and deconstructions of terrain and furniture will use
lc_wire
only, except:Light, heavy, old, electronic machinery may drop all grades of wire
Reinforced glass drops medium steel wire
Loot
Itemgroups such as steel mill, farm supplies, hardware stores, exodii metal supplies may contain all grades of wire
Items, recipes, uncrafts
Most recipes where wire grade does not matter uses
any_wire
requirement groupwire baskets and cages use lc_wire only
remove the recipe that converts wire to scrap
remove the recipe that makes wire from scrap (all wire is now made from matching graded steel lump)
mattresses no longer drop springs, instead drop high steel wire
chainmail
Create a migration for
chain_link
tolc_chain_link
Create a migration for
link_sheet
tolc_link_sheet
All recipes that use
chain_link
orlink_sheet
now use appropriate graded steel versionsDescribe alternatives you've considered
Not using an
any_wire
requirement group, or using it lessTesting
Create a world without changes. Spawn items. Update to include changes. Verify proper migration and handling.
Additional context
You know, it would be best if we just got rid of medium steel altogether.
Mild steel > case hardened steel
High steel > tempered steel
Pretty elegant I think. Medium steel makes the existence of case hardened and high steels complicated.
But that's an issue for another... issue.