-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow pipe cleaner to be crafted using any sort of wire #76187
allow pipe cleaner to be crafted using any sort of wire #76187
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Anything I need to do? I guess there were conflicting changes unrelated to what this is doing? |
It made me realize we were missing a piece in the recipe to make a pipe cleaner so I fixed that here and in base game. You are good. |
Doesn't the act of cleaning already use a piece of cloth? Why would a pipe cleaner need an integrated piece of cloth/wool? |
Real simple. This is a word/action confusion. A random piece of wire isn't a pipe cleaner. It's only a pipe cleaner with the integrated cloth/wool. Now, if someone wants to change the action of cleaning to use either a pre-made pipe cleaner or any random wire plus a piece of cloth, go for it. I might even do it if I find time and remember. |
I see. I thought it was already the case that it used a piece during the mend process. Was that a recent change? I could have sworn I needed to carry consumable cleaning supplies (and not just tools) with me for unfouling my BP guns just a few months ago. in toolsets.json:
So doesn't this mean you need a cotton ball to CRAFT the pipe cleaner, and then you USE another cotton ball to actually clean the gun? Doesn't this double up on the cotton ball or am I missing something? |
Summary
None
Purpose of change
Adjusts pipe cleaner recipe to allow for the use of any types of wire
Describe the solution
Modifies the recipe to include all the types of wire (mild, tempered, etc...) as for this tool the type likely does not matter.
Describe alternatives you've considered
Testing
Additional context