Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow pipe cleaner to be crafted using any sort of wire #76187

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

misterprimus
Copy link
Contributor

@misterprimus misterprimus commented Sep 4, 2024

Summary

None

Purpose of change

Adjusts pipe cleaner recipe to allow for the use of any types of wire

Describe the solution

Modifies the recipe to include all the types of wire (mild, tempered, etc...) as for this tool the type likely does not matter.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mods: Innawood 🌲 Anything to do with Innawood mod labels Sep 4, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 4, 2024
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 4, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 4, 2024
@misterprimus
Copy link
Contributor Author

Anything I need to do? I guess there were conflicting changes unrelated to what this is doing?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2024
@Maleclypse
Copy link
Member

Anything I need to do? I guess there were conflicting changes unrelated to what this is doing?

It made me realize we were missing a piece in the recipe to make a pipe cleaner so I fixed that here and in base game. You are good.

@Maleclypse Maleclypse merged commit 67159f2 into CleverRaven:master Sep 5, 2024
19 of 24 checks passed
@misterprimus
Copy link
Contributor Author

Anything I need to do? I guess there were conflicting changes unrelated to what this is doing?

It made me realize we were missing a piece in the recipe to make a pipe cleaner so I fixed that here and in base game. You are good.

Doesn't the act of cleaning already use a piece of cloth? Why would a pipe cleaner need an integrated piece of cloth/wool?

@Maleclypse
Copy link
Member

Anything I need to do? I guess there were conflicting changes unrelated to what this is doing?

It made me realize we were missing a piece in the recipe to make a pipe cleaner so I fixed that here and in base game. You are good.

Doesn't the act of cleaning already use a piece of cloth? Why would a pipe cleaner need an integrated piece of cloth/wool?

Real simple. This is a word/action confusion. A random piece of wire isn't a pipe cleaner. It's only a pipe cleaner with the integrated cloth/wool. Now, if someone wants to change the action of cleaning to use either a pre-made pipe cleaner or any random wire plus a piece of cloth, go for it. I might even do it if I find time and remember.

@misterprimus
Copy link
Contributor Author

misterprimus commented Sep 5, 2024

Anything I need to do? I guess there were conflicting changes unrelated to what this is doing?

It made me realize we were missing a piece in the recipe to make a pipe cleaner so I fixed that here and in base game. You are good.

Doesn't the act of cleaning already use a piece of cloth? Why would a pipe cleaner need an integrated piece of cloth/wool?

Real simple. This is a word/action confusion. A random piece of wire isn't a pipe cleaner. It's only a pipe cleaner with the integrated cloth/wool. Now, if someone wants to change the action of cleaning to use either a pre-made pipe cleaner or any random wire plus a piece of cloth, go for it. I might even do it if I find time and remember.

I see. I thought it was already the case that it used a piece during the mend process. Was that a recent change? I could have sworn I needed to carry consumable cleaning supplies (and not just tools) with me for unfouling my BP guns just a few months ago.

in toolsets.json:

  {
    "id": "gun_cleaning",
    "type": "requirement",
    "//": "Gun cleaning",
    "qualities": [ { "id": "SCREW", "level": 1 } ],
    "tools": [ [ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] ],
    "components": [
      [
        [ "gasoline", 125 ],
        [ "diesel", 125 ],
        [ "chem_ethanol", 125 ],
        [ "chem_methanol", 125 ],
        [ "methed_alcohol", 125 ],
        [ "denat_alcohol", 125 ],
        [ "chem_acetone", 1 ],
        [ "chem_chloroform", 125 ],
        [ "ether", 125 ],
        [ "chem_DMSO", 125 ],
        [ "vinegar", 8 ],
        [ "ammonia_hydroxide", 1 ],
        [ "bleach", 1 ]
      ],
      [ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ]
    ]
  },

So doesn't this mean you need a cotton ball to CRAFT the pipe cleaner, and then you USE another cotton ball to actually clean the gun? Doesn't this double up on the cotton ball or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants