Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #70721 (move prosthetics etc to WIP limb mod) for 0.H #76175

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Backport #70721 (move prosthetics etc to WIP limb mod) for 0.H #76175

merged 3 commits into from
Sep 7, 2024

Conversation

harakka
Copy link
Member

@harakka harakka commented Sep 3, 2024

Summary

None

Purpose of change

Backport #70721 (move prosthetics etc to WIP limb mod) for 0.H stable. I've been going back and forth on doing this, but I think breaking it now for the few people playing 0.H release candidates as amputee characters, is better than breaking it eventually for more people when 0.H users migrate to 0.I. This is based on the assumption 0.I won't have the limb mod completed. If it gets completed, this was for vain but I'm hopeful the affected people can live with it. If they have backups, they can also enable the WIP limb mod for their 0.H saves.

Describe the solution

Describe alternatives you've considered

Only obsoleting the amputee starts so that 0.H users can't get the start by rolling random characters.

Testing

Additional context

Check that default world doesn't have the amputee stuff, check that world with mod enabled does and you can start as an amputee.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Spawn Creatures, items, vehicles, locations appearing on map Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios Code: Tooling Tooling that is not part of the main game but is part of the repo. Mechanics: Enchantments / Spells Enchantments and spells Items: Armor / Clothing Armor and clothing EOC: Effects On Condition Anything concerning Effects On Condition Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Mind Over Matter <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 3, 2024
@Venera3 @harakka
Add WIP Limb Stuff mod and move mainline limby stuff over (CleverRave…
16a5a81 
…n#70721)

* First migration

* Second

* Migration

From Hell's Heart I lint at thee

We'll get there

* Ravenfolk fix

Actual fix fix maybe?

Fix fix fix + test armor

Imma have to squash this mess to oblivion

I swear to Glob

This is getting awkward

* Done playin
@github-actions github-actions bot added the Mods: Magiclysm Anything to do with the Magiclysm mod label Sep 4, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 6, 2024
@Maleclypse Maleclypse merged commit c513797 into CleverRaven:0.H-branch Sep 7, 2024
22 of 23 checks passed
@harakka harakka mentioned this pull request Oct 1, 2024
Merged
Maleclypse pushed a commit that referenced this pull request Oct 6, 2024
@harakka @RenechCDDA
Backport #76175 (grass regrows for grazing) to 0.H (#76855)
f4a8c53 
* Make grazing actually work, with grass regrowth

* No copy-from

---------

Co-authored-by: RenechCDDA <84619419+RenechCDDA@users.noreply.github.com>
@harakka harakka deleted the 0-h_backport_70721_limb_mod branch October 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tooling Tooling that is not part of the main game but is part of the repo. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition Info / User Interface Game - player communication, menus, etc. Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Innawood 🌲 Anything to do with Innawood mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harakka @Maleclypse @Venera3