avoid crashing on SIGINT by not redrawing the UI #76173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not really much point in redrawing the UI when we’re about to be killed anyway. Fixes CleverRaven#76130
github-actions
bot
added
[C++]
|
This is not complete, or even correct:
I think my PR (#75999) is the better solution; it just needs a couple of finishing touches. |
|
You are entirely correct, but this patch doesn’t make the current situation any worse and yours isn’t ready yet. If yours gets merged first then this one will have merge conflicts and we can just close it. If mine is merged first then it won't delay yours any. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "avoid crashing on SIGINT by not redrawing the UI"
Purpose of change
Fixes #76130