-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use snippets instead of static responses in dialogs #76102
base: master
Are you sure you want to change the base?
Conversation
just heads up, we try to not make PRs bigger than 500 strings, because they are barely reviewable. Is it possible for you to divide it? |
I know, my bad. But is there any point in breaking the PR into several parts if the work is already done? Isn't it better to break it here into smaller commits (~300 lines)? If this is still needed, I will break it into several parts, just let me know (for now I've split the commits into smaller ones vvvvv) |
7cc5c24
to
343c047
Compare
it's not about making separate commits, it's about merger being able to read the PR in one go |
343c047
to
44637e1
Compare
Okay, I thought the merger would look at reviews from other participants. Then I'll split it into ~4 PRs later. Although the first one will still be big due to copy-pasting pieces from a monolithic |
44637e1
to
1d5e942
Compare
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Done. |
Summary
Infrastructure "Replace some player responses with snippets"
Purpose of change
We have a category of snippets for player responses that end a dialogue. But they were rarely used. It would be convenient to have all these typical responces in one place.
Describe the solution
Replace static answers in
TALK_NONE
andTALK_DONE
with snippets.Snippets are now split into multiple files and several new categories.
talk_tags.json
now contains only small snippets.<wpunc>
- same as<punc>
, but the snippets have weight instead of equal probabilitytalk_tags_avatar.json
contains the player's responses.<end_talking_bye>
,<end_talking_later>
,<end_talking_leave>
,<end_talking_nevermind>
,<end_talking_later_follower>
- the corresponding snippets and replaced text are sorted into these categoriestalk_tags_line.json
contains snippets with full sentences.<lets_go>
snippetDescribe alternatives you've considered
Testing
I looked through all the changes in this PR, as for me all the replacements look correct. The game also did not give any errors when loading with data verification.
Additional context