move NoScrollbar and NoScrollWithMouse flags from cataimgui::window to uilist_impl #75971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
I noticed scrollbars and mouse scrolling were disabled when I started working on #73456 again. Looking into it it was disabled as part of the uilist migration, but that was erroneously done on the base imgui window and not the specific implementation.
I'm not sure if this broke any already existing imgui windows. The keybindings menu at least uses a table for scrolling, so it was unaffected.
Describe the solution
Move the flags from the general window to the specific uilist_impl, so other windows can use mouse scrolling.
Describe alternatives you've considered
Testing
uilist still scrolls through entries with mouse wheel.
Additional context