Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spellcast adjustment not working #75805

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Spellcast adjustment didn't apply it's effect

Describe the solution

Tweak code so it actually works

Testing

  {
    "type": "effect_on_condition",
    "id": "EOC_metamagic_extend",
    "eoc_type": "EVENT",
    "required_event": "opens_spellbook",
    "effect": [
      { "math": [ "u_spellcasting_adjustment('duration', 'flag_blacklist': 'PERMANENT_ALL_LEVELS' )", "=", "10.0" ] },
      { "math": [ "u_spellcasting_adjustment('cost', 'flag_blacklist': 'PERMANENT_ALL_LEVELS' )", "=", "0.5" ] }
    ]
  },

with this eoc, all spells always have 10 times bigger duration than before
(i lost the screenshots with in game tests :( )

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Aug 18, 2024
@github-actions github-actions bot requested a review from KorGgenT August 18, 2024 18:37
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 18, 2024
@dseguin dseguin merged commit 94a2d4d into CleverRaven:master Aug 20, 2024
22 of 28 checks passed
@GuardianDll GuardianDll deleted the fix_spellcast_adj_duration branch August 20, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants