Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Superglue Recipe #75492

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Holli-Git
Copy link
Contributor

Summary

Bugfixes "Removes superglue recipe"

Purpose of change

Superglue has a much more complex recipe IRL than what it currently is, and while it in theory could be made, it'd be quite impractical and difficult to do.

Describe the solution

Removes the recipe, and has innawoods migrate it into bone glue.

Describe alternatives you've considered

Not doing this

Testing

Recipe before:
image
Recipe after (there is nothing):
image
Here is the migration working innawoods:
image

Additional context

Gonna try cooking up a PR that makes superglue spawn in multiple amounts in a proper tube, though that may be a bit

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Innawood 🌲 Anything to do with Innawood mod <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 6, 2024
@casswedson
Copy link
Contributor

it'd be quite impractical and difficult to do.

I would love to hear all about this

@Holli-Git
Copy link
Contributor Author

Holli-Git commented Aug 6, 2024

I would love to hear all about this

From my google-fu, the process would involve formaldehyde, chlorine, sulfuric acid, and cyanide

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 6, 2024
@ADekema
Copy link

ADekema commented Aug 7, 2024

Removing the recipe outright is pretty drastic. Superglue is used for a whole bunch of recipes. Would it be possible to rework the recipe to a makeshift glue strong enough to be a substitute for modern superglue?

@Holli-Git
Copy link
Contributor Author

Removing the recipe outright is pretty drastic. Superglue is used for a whole bunch of recipes. Would it be possible to rework the recipe to a makeshift glue strong enough to be a substitute for modern superglue?

No.

@Inglonias
Copy link
Contributor

i support this on the grounds that it's hilarious.

@kevingranade kevingranade merged commit d74e076 into CleverRaven:master Aug 8, 2024
20 of 26 checks passed
@sonphantrung
Copy link
Contributor

sonphantrung commented Aug 8, 2024

Removing the recipe outright is pretty drastic. Superglue is used for a whole bunch of recipes. Would it be possible to rework the recipe to a makeshift glue strong enough to be a substitute for modern superglue?

I've never really relied on crafting superglues, as they are very common in the (vanilla) game. Most of the said recipes can be replaced by duct tapes iirc, which are also common.

Edit: there's also bone glue.

@Holli-Git Holli-Git deleted the remove_superglue_recipe branch August 8, 2024 15:38
@adamkad1
Copy link
Contributor

adamkad1 commented Aug 9, 2024

Removing the recipe outright is pretty drastic. Superglue is used for a whole bunch of recipes. Would it be possible to rework the recipe to a makeshift glue strong enough to be a substitute for modern superglue?

No.

How mature.

Also didnt we use to require irl examples for stuff? And not just 'it would be too hard or impractical or something'

@Holli-Git
Copy link
Contributor Author

How mature.

How is this immature?

Also didnt we use to require irl examples for stuff? And not just 'it would be too hard or impractical or something'

The synthesis requires reacting ethyl alcohol and sulfuric acid at 100C refluxing for a few hours to produce ethyl chloroacetate. That product is then reacted with sodium cyanide to create ethyl cyanoacetate. It is then reacted with formaldehyde to produce superglue. Note, this is not impossible, just much more complex than the current recipe. If you feel like making a PR to add a superglue recipe, by all means, go for it. But at the end of the day it is not my job, or anybodys job, to make a recipe for superglue.

@Roet718
Copy link

Roet718 commented Aug 10, 2024

But it is your job to indefinitely wreck a significant portion of the game with no clear plans to remedy those issues, simply because of some "google-fu"? I don't mean to be rude but I just don't see any benefit to making this change now, instead of at a later time bundled with at least some attempt at the relevant recipe adjustments.

@CleverRaven CleverRaven locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Innawood 🌲 Anything to do with Innawood mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants