Optimize typed coordinate conversion functions for faster Windows unsafe_get_submap_at performance

src/cata_inline.h

@@ -0,0 +1,13 @@
+#pragma once
+#ifndef CATA_SRC_CATA_INLINE_H
+#define CATA_SRC_CATA_INLINE_H
+
+#ifndef CATA_FORCEINLINE
+#ifdef _MSC_VER
+#define CATA_FORCEINLINE __forceinline
+#else
+#define CATA_FORCEINLINE inline __attribute__((always_inline))
+#endif
+#endif
+
+#endif // CATA_SRC_CATA_INLINE_H

src/coords_fwd.h

@@ -2,6 +2,8 @@
 #ifndef CATA_SRC_COORDS_FWD_H
 #define CATA_SRC_COORDS_FWD_H
 
+#include <type_traits>
+
 struct point;
 struct tripoint;
 
@@ -32,8 +34,15 @@ constexpr scale omt = scale::overmap_terrain;
 constexpr scale seg = scale::segment;
 constexpr scale om = scale::overmap;
 
+template<typename Point, origin Origin, scale Scale>
+class coord_point_ob;
+
+template<typename Point, origin Origin, scale Scale>
+class coord_point_ib;
+
 template<typename Point, origin Origin, scale Scale, bool InBounds = false>
-class coord_point;
+using coord_point =
+    std::conditional_t<InBounds, coord_point_ib<Point, Origin, Scale>, coord_point_ob<Point, Origin, Scale>>;
 
 } // namespace coords
 

src/map.cpp

@@ -1805,7 +1805,7 @@ furn_id map::furn( const tripoint &p ) const
     return furn( tripoint_bub_ms( p ) );
 }
 
-furn_id map::furn( const tripoint_bub_ms &p ) const
+furn_id map::furn( const tripoint_bub_ms p ) const
 {
     if( !inbounds( p ) ) {
         return furn_str_id::NULL_ID();
@@ -2000,7 +2000,7 @@ std::string map::furnname( const tripoint_bub_ms &p )
  * retained for high performance comparisons, save/load, and gradual transition
  * to string terrain.id
  */
-ter_id map::ter( const tripoint &p ) const
+ter_id map::ter( const tripoint p ) const
 {
     if( !inbounds( p ) ) {
         return ter_str_id::NULL_ID().id();

src/map.h

@@ -965,7 +965,7 @@ class map
         }
         // TODO: fix point types (remove the first overload)
         furn_id furn( const tripoint &p ) const;
-        furn_id furn( const tripoint_bub_ms &p ) const;
+        furn_id furn( tripoint_bub_ms p ) const;
         // TODO: Get rid of untyped overload.
         furn_id furn( const point_bub_ms &p ) const {
             return furn( tripoint_bub_ms( p, abs_sub.z() ) );
@@ -1010,7 +1010,7 @@ class map
 
         // Terrain
         // TODO: fix point types (remove the first overload)
-        ter_id ter( const tripoint &p ) const;
+        ter_id ter( tripoint p ) const;
         ter_id ter( const tripoint_bub_ms &p ) const;
         // TODO: Get rid of untyped overload.
         ter_id ter( const point &p ) const {
@@ -2399,11 +2399,9 @@ class map
             offset_p.y = p.y % SEEY;
             return unsafe_get_submap_at( p );
         }
-        submap *unsafe_get_submap_at( const tripoint_bub_ms &p, point_sm_ms &offset_p ) {
+        submap *unsafe_get_submap_at( const tripoint_bub_ms p, point_sm_ms &offset_p ) {
             tripoint_bub_sm sm;
-            point_sm_ms_ib l;
-            std::tie( sm, l ) = project_remain<coords::sm>( p );
-            offset_p = point_sm_ms( l );
+            std::tie( sm, offset_p ) = project_remain<coords::sm>( p );
             return unsafe_get_submap_at( p );
         }
         // TODO: fix point types (remove the first overload)
@@ -2413,11 +2411,9 @@ class map
             return unsafe_get_submap_at( p );
         }
         const submap *unsafe_get_submap_at(
-            const tripoint_bub_ms &p, point_sm_ms &offset_p ) const {
+            const tripoint_bub_ms p, point_sm_ms &offset_p ) const {
             tripoint_bub_sm sm;
-            point_sm_ms_ib l;
-            std::tie( sm, l ) = project_remain<coords::sm>( p );
-            offset_p = point_sm_ms( l );
+            std::tie( sm, offset_p ) = project_remain<coords::sm>( p );
             return unsafe_get_submap_at( p );
         }
         // TODO: Get rid of untyped overload

src/mdarray.h

@@ -16,14 +16,14 @@ namespace cata
 template<typename Point>
 struct mdarray_default_size_impl;
 
-template<typename Point, coords::scale Scale, bool InBounds>
-struct mdarray_default_size_impl<coords::coord_point<Point, coords::origin::reality_bubble, Scale, InBounds>> {
+template<template<class, coords::origin, coords::scale> class coord_point, typename Point, coords::scale Scale>
+struct mdarray_default_size_impl<coord_point<Point, coords::origin::reality_bubble, Scale>> {
     static constexpr size_t value = MAPSIZE_X / map_squares_per( Scale );
     static_assert( MAPSIZE_X % map_squares_per( Scale ) == 0, "Scale must be smaller than map" );
 };
 
-template<typename Point, coords::origin Origin, coords::scale Scale, bool InBounds>
-struct mdarray_default_size_impl<coords::coord_point<Point, Origin, Scale, InBounds>> {
+template<template<class, coords::origin, coords::scale> class coord_point, typename Point, coords::origin Origin, coords::scale Scale>
+struct mdarray_default_size_impl<coord_point<Point, Origin, Scale>> {
     static constexpr coords::scale outer_scale = coords::scale_from_origin( Origin );
     static constexpr size_t value = map_squares_per( outer_scale ) / map_squares_per( Scale );
     static_assert( value > 0, "Scale must be smaller origin" );

src/omdata.h

@@ -77,7 +77,7 @@ std::string name( type dir );
 point rotate( const point &p, type dir );
 tripoint rotate( const tripoint &p, type dir );
 template<typename Point, coords::scale Scale>
-auto rotate( const coords::coord_point<Point, coords::origin::relative, Scale> &p, type dir )
+auto rotate( const coords::coord_point_ob<Point, coords::origin::relative, Scale> &p, type dir )
 -> coords::coord_point<Point, coords::origin::relative, Scale>
 {
     return coords::coord_point<Point, coords::origin::relative, Scale> { rotate( p.raw(), dir ) };

tests/coordinate_test.cpp

@@ -18,13 +18,12 @@ static_assert( tripoint_abs_omt::dimension == 3 );
 
 // Out of bounds coords can be implicitly constructed from inbounds ones. This is used
 // to ensure a return type is NOT an inbounds one, before it can be converted.
-template <typename Point, coords::origin Origin, coords::scale Scale, bool InBounds>
-coords::coord_point<Point, Origin, Scale, InBounds> assert_not_ib( const
-        coords::coord_point<Point, Origin, Scale, InBounds> &p )
-{
-    static_assert( !InBounds );
-    return p;
-}
+#define assert_not_ib(p) \
+    (([](auto&& _p) { \
+        using _t = decltype(_p); \
+        static_assert(!std::decay_t<_t>::is_inbounds); \
+        return std::forward<_t>(_p); } \
+     )(p))
 
 TEST_CASE( "coordinate_strings", "[point][coords][nogame]" )
 {