Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artificial Night Generator do not grant invis #74947

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

The invis field in night generator appeared from nowhere when it was migrated from code to enchantment, without any reason
Close #74366

Describe the solution

Make it not give invis, so it is useful against monsters that do not have a good night vision, but is useless against one that do, instead of being Cloaking System but cheaper

Testing

Debug installed cbm, turned on, zombies do not see me, night stalkers do see me

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 8, 2024
@Fris0uman
Copy link
Contributor

Fris0uman commented Jul 8, 2024

I'm 90% sure that the hardcoded version already gave invisibility
Not really a reason to keep it though, just saying I don't think it came from nowhere

@Daved27hundred
Copy link
Contributor

Daved27hundred commented Jul 8, 2024

only somewhat related but I noticed this discrepancy between the description of the Artificial night generator item and the installed bionic, if you could fix it too. The range of the field is drastically different in both descriptions.
image
image

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 9, 2024
@Maleclypse Maleclypse merged commit 5bfa3c4 into CleverRaven:master Jul 9, 2024
24 checks passed
@GuardianDll GuardianDll deleted the foo branch July 9, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artificial Night Generator shouldn't grant full invisibility
4 participants