Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Rework Passive traits to use spell_level_sum #73569

Merged
merged 12 commits into from
May 9, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 7, 2024

Summary

Mods "[MoM] Rework Passive traits to use spell_level_sum"

Purpose of change

Now that spell_level_sum exists, it's a better indication of your overall mastery than school_level

Describe the solution

Rework the formulas to account for total power levels in a psionic path, not simply the highest power level. Adjust the bonus per level to account for this.

Also the lifting field recipe didn't allow you to contemplate it in a crystal cluster field, so I fixed that, and edited the description to make it more obvious how it works.

Describe alternatives you've considered

Testing

Made a character with every psionic path, walked around a bit, waited a while. No errors.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft May 7, 2024 17:10
@Standing-Storm Standing-Storm changed the title [MoM] Rework Passive powers to use spell_level_sum [MoM] Rework Passive traits to use spell_level_sum May 7, 2024
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels May 7, 2024
Standing-Storm and others added 6 commits May 7, 2024 14:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 7, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 7, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review May 8, 2024 01:58
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 8, 2024
@Maleclypse Maleclypse merged commit d268840 into CleverRaven:master May 9, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the passive-powers branch May 9, 2024 02:08
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants