Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added to greater dimensional bag to enchanted_misc item group #73564

Merged
merged 1 commit into from
May 9, 2024
Merged

Added to greater dimensional bag to enchanted_misc item group #73564

merged 1 commit into from
May 9, 2024

Conversation

Sofistico
Copy link
Contributor

Summary

Mods "add greater dimensional bag to be spawned"

Purpose of change

I saw #70000 and decided to do something about it
fix #70000

Describe the solution

Added greater dimensional bag to enchanted_misc, also upped the probability of bag_holding_2 since bag_holding_3 is now obtainable, it should be rarer than bag_holding_2.

Describe alternatives you've considered

Not doing it.

Testing

  1. Creating a new character
  2. Go visiting various forge of wonder
  3. Check if the item spawned

Additional context

N/A

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) labels May 7, 2024
@github-actions github-actions bot requested a review from KorGgenT May 7, 2024 13:12
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 7, 2024
@Maleclypse Maleclypse merged commit 5b4a634 into CleverRaven:master May 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Magiclysm] Greater Dimensional Bag Unobtainable
2 participants
@Sofistico @Maleclypse