-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integrated armor being incompatible with some mutations #73547
Conversation
Integrated armor shouldn't care about fitting in the first place. The right solution is to disable the janky checks, not add every missing flag ( |
Yeah I just wasn't sure if something would break in such a case. I'll get to it in a bit then. |
Should be ready now. |
I'll wait for Venera to approve the change to the PR but I've adjusted the name of the PR. Please check and see if that works then apply in Summary if you agree. |
Add the bypassed checks to the |
Will do tomorrow, it's late here, will ping you both when I do it. |
@Venera3 @Maleclypse Sorry I forgot yesterday, doc line is added now. |
Summary
Bugfixes "Fix integrated armor being incompatible with some mutations"
Purpose of change
#71874 added integrated fangs, but apparently nobody noticed that snouts conflict with them, sometimes not allowing you to get fangs despite having the mutation.
Describe the solution
Make integrated armor act as OVERSIZE by having INTEGRATED skip any checks OVERSIZE does.
Describe alternatives you've considered
N/A
Testing
I don't think testing is needed here honestly, it's literally modifying a few checks in a simple manner.
Additional context
N/A