Amphibian Additions - Final Frogs

[TheSaddestGoomba]

Summary

Content "Adds the last remaining natural frog species native to New England."

Purpose of change

Round out the remaining frogs of New England. Bring them to parity with the existing creatures by including a few mutant varieties.

Describe the solution

Adds new creatures, adult frogs and tadpoles, for the remaining natural species common to New England:

• Mink Frog
• Pickerel Frog
• Green Frog
• Wood Frog
• Spadefoot Toad

Additionally adds mutants: I'll be implementing these in their own PR

• from Mink Frogs, the Tailed Frog becomes the Musk Frog; big mutants that nest in muddy burrows created with their tails
• from Pickerel Frogs, the Palette Frog becomes the Painter Frog; big-ish mutant that sheds poisonous fluids of bright warning colors
• from Green, Wood, and Leopard Frogs, the Many-Legged Frog becomes the Skittering Frog, and then a Wormhost Frog

Describe alternatives you've considered

Settling for fewer frogs

Testing

Did some hours of flyover spawn testing. All new monsters appeared through normal map gen.
Tested hatching/growing/laying in large batches. Everything checked out, many-legged frogs are appropriately rare.
Tested dissection and butchery for each monster.
Tamed all frogs with Tamable Wildlife.

Additional context

6th implementation of #67029 which I sorely need to update

Will need to be merged after #72413

This includes the last new frogs from New England but won't be my last frog-related PR. I have a list of things to polish before I consider moving onto salamanders. I also have a few more oddball frog mutants that may come down the road.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• The eastern variety of the American spadefoot toad is a squat, round toad with vertical pupils. Its body is colored a muddy mixture of browns, tans, and yellow-greens. Their name comes from the keratinous projection on their hind legs that aids them in digging.
• This very large, funky frog has an accentuated, paddle-like tail that accounts for half its bodymass. It is green with many brown spots scattering across its back.
• You're quite sure that no frog this bright and garish could be native to New England. Most of its skin is a light brown, but the large, squarish patches on its back are all of very different hues and vibrancies.
• spadefoot toad
• spadefoot toads

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[github-actions]

Auto-requesting reviews from non-collaborators: @Termineitor244

[I-am-Erk]

Just a heads up that this has sparked a fair bit of conversation about what how much detail we should be supporting in monsters with our current stats. I don't think you need to change this PR, it looks good and you've clearly worked hard and nothing in it is inappropriate. however, I'd like to ask that you hold off on further big additions of cosmetic creature variants until we've had a chance to determine what the best way to manage this kind of content is, because I don't think our current systems for it work really great. It winds up being a lot of lines of JSON to manage, when taken as a whole.

In a larger sense, we've needed a system for monster variants for a long time, and these are really starting to get down to the heart of it. there are a lot of lines of monstergroup information here that basically amount to different spawning weights for variants of the "frog" abstract, with creatures that are functionally just a reskinned frog. If you're able to see a way to streamline that with existing tools it'd be cool but in the big picture I think we need to push for some new infrastructure for that, and move stuff like frogs into it. until we have that, I think we should hold off on any further high-detail variants of creatures like this. I'll post an issue with more details.

[TheSaddestGoomba]

Just a heads up that this has sparked a fair bit of conversation about what how much detail we should be supporting in monsters with our current stats...

I've noticed the json bloat growing myself, so right there with you. This is the last big addition like this I had planned. I have mentioned salamanders but they are very much an "at some vague future date" addition. I won't do anything with those until a proper variants system is in place (even then they may need to be abridged, there's even more species of them than frogs).

If you're able to see a way to streamline that with existing tools it'd be cool but in the big picture I think we need to push for some new infrastructure for that...

After this PR I'm turning towards polishing what I've added. I can definitely do some cleanup/json reduction with groups. I have an idea of how to remove half of the eggs and tadpoles, but I'll need to check if it functions the way I think it does.