Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bronze chisel attempt 2 now with recipe #71904

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

Consoleable
Copy link
Contributor

@Consoleable Consoleable commented Feb 21, 2024

NOTE: Please grant permission for repository maintainers to edit your PR. It is EXTREMELY common for PRs to be held up due to trivial changes being requested and the author being unavailable to make them. -->

Summary

Content "Added bronze chisel"

Purpose of change

With the addition of bronze metalworking tools, steel chisels were the only option for making bronze items, i have added bronze chisels as an option for the greek at heart. Bronze chisels have chiseling quality 2 and wood chiseling quality 2, so they cannot be used to make steel items.
Bronze chisels can also be used to make jewelry and glassware.

Describe the solution

Describe alternatives you've considered

I anticipate a debate on whether or not it should have chiseling 3 or chiseling 2. It is possible to chisel hot steel with bronze tools, but not all the recipes which require chiseling 3 are "hot" recipes, and not everyone wants bronze tools to work on steel projects. Bronze projects are easier to chisel as a matter of fact, and there are several recipes, like chipping rocks, which do not necessarily require steel. We may want to make the bronze chisel chiselling 3 later, but for now it would make sense to reduce the chiseling quality required for the aforementioned projects and make the bronze chisel quality 2 so that the relative effectiveness of the bronze chisel is more closely aligned with its reason for being added and to satisfy the most verisimilitude.(It should AT LEAST be useful for bronze working but MAYBE NOT for steelworking. It can be upgraded later but in the meantime I can lower chiseling requirements for some recipes, such as glassware and jewelry.)

Testing

added bronze chisel to game, used it to make zinc

Additional context

It has wood chiseling quality 2 so that it cannot make hygrometers, which are the only item that uses wood chiseling 3, and as i understand it actually require a chisel to be used on the steel components.

Copy link
Contributor

You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions labels Feb 21, 2024
@github-actions github-actions bot added the Items: Containers Things that hold other things label Feb 21, 2024
@github-actions github-actions bot added the Items: Armor / Clothing Armor and clothing label Feb 21, 2024
@Consoleable Consoleable marked this pull request as ready for review February 21, 2024 21:16
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 21, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 22, 2024
@Maleclypse Maleclypse merged commit abc0c36 into CleverRaven:master Feb 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants