-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect zombies via copy-from
- Part 1
#71170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2024
cd60e5c
to
17b0f58
Compare
e3454e6
to
16eed79
Compare
Merged
copy-from
copy-from
- Part 1
I would like to have this be merged first before trying to start a part 2. And I think that with all the other PRs setting ground this should be ready save for one thing. I need to figure out what's causing the tileset regression in resort staff zombies mentioned in #71199... |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
copy-from
for monsters specifically works fairly well, and when recently I considered auditing default human body sizes... I found out our zombies aren't linked, so to audit the sizes for them I'd have to go through all of them manually. I am not aware of any reason for this, so I opted to give them the same treatment I did for ferals by chaining them to a base monster that they'd be able to copy from.Describe the solution
CLASSIC
category, since otherwise I'd have to have most zombies overwrite that field); same for abstract baseline childrenOTHER CHANGES
proportional
RANGED_ATTACKER
to the corrosive zombieRANGED_ATTACKER
from acidic zombie and the wretched puker because they weren't actually rangedSMELLS
from some zombies that didn't make sense to have it, like generic acidics or children (nor did they have scents defined, so it didn't work to my knowledge)proportional
KEENNOSE
)TODO
NO_FUNG_DMG
flag negatesfungalizes_into
field, figure out how to overwrite the field otherwiseDescribe alternatives you've considered
Testing
Additional context